Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no ActionTaskOutput table waring #28149

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 21, 2023

Reproduce:

  • Create a new Gitea instance
  • Register a runner
  • Create a repo and add a workflow
  • Check the log, you will see warnings:
    image
    It comes from:
    image

The reason is that we forgot registering ActionTaskOutput model.
So action_table_output table will be missing in your db.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2023
@wolfogre wolfogre added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 21, 2023
@wolfogre
Copy link
Member

wolfogre commented Nov 21, 2023

It will fix https://gitea.com/gitea/act_runner/issues/337

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2023
@lunny lunny enabled auto-merge (squash) November 21, 2023 07:39
@lunny lunny merged commit 976a992 into go-gitea:main Nov 21, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 21, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 21, 2023
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
@yp05327 yp05327 deleted the fix-no-actiontaskoutput-table branch November 21, 2023 08:03
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 21, 2023
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
lunny pushed a commit that referenced this pull request Nov 21, 2023
Backport #28149 by @yp05327

Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.

Co-authored-by: yp05327 <576951401@qq.com>
lunny pushed a commit that referenced this pull request Nov 21, 2023
Backport #28149 by @yp05327

Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.

Co-authored-by: yp05327 <576951401@qq.com>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Nov 21, 2023
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.20. @yp05327, please send one manually. 🍵

go run ./contrib/backport 28149
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 21, 2023
@lunny lunny added the backport/done All backports for this PR have been created label Nov 22, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2023
* giteaofficial/main:
  Fix the description about the default setting for action in quick start document (go-gitea#28160)
  Do not display search box when there's no packages yet (go-gitea#28146)
  Add guide page to actions when there's no workflows (go-gitea#28145)
  Fix no ActionTaskOutput table waring (go-gitea#28149)
  Fix empty action run title (go-gitea#28113)
  Use "is-loading" to avoid duplicate form submit for code comment (go-gitea#28143)
  Fix typo in `packages.cleanup.success` (go-gitea#28133)
  Add edit option for README.md (go-gitea#28071)
  Remove autofocus in search box (go-gitea#28033)
  Add missing `packages.cleanup.success` (go-gitea#28129)
  Update docs for docusaurus v3 (go-gitea#28125)
@yp05327
Copy link
Contributor Author

yp05327 commented Nov 22, 2023

image
@lunny
So we do not need to backport to 1.20?

@lunny
Copy link
Member

lunny commented Nov 22, 2023

image @lunny So we do not need to backport to 1.20?

Sorry, my wrong. I just thought there are already two backports from the references, but in fact they are the same PR. Please send the backport manually.

@yp05327
Copy link
Contributor Author

yp05327 commented Nov 22, 2023

@lunny
Ah, I'm sorry, I didn't notice that there are already two backports. We do not need send the backport again.
It is strange why bot post this. 🤔

@yp05327
Copy link
Contributor Author

yp05327 commented Nov 22, 2023

Maybe this is caused by delete branch? 🤔
image

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f1278e0-114b-48bc-8113-8ba1404d9975)
It comes from:

![image](https://github.com/go-gitea/gitea/assets/18380374/c2807831-e137-4229-9536-87f6114c8a5b)

The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants