Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HTTP method in test error message #2815

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

ethantkoenig
Copy link
Member

Useful when debugging a failed test

@lunny lunny added this to the 1.3.0 milestone Nov 1, 2017
@lunny
Copy link
Member

lunny commented Nov 1, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2017
@codecov-io
Copy link

Codecov Report

Merging #2815 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2815   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a97b6...b543cbc. Read the comment docs.

@appleboy
Copy link
Member

appleboy commented Nov 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2017
@appleboy appleboy merged commit 1b6a962 into go-gitea:master Nov 1, 2017
@ethantkoenig ethantkoenig deleted the test/err_msg branch November 10, 2017 04:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants