Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong translations #2818

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Fix wrong translations #2818

merged 2 commits into from
Nov 1, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 1, 2017

As title.

@lunny lunny added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 1, 2017
@lunny lunny added this to the 1.3.0 milestone Nov 1, 2017
jonasfranz
jonasfranz approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@jonasfranz jonasfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, since it simply moves some steps from make update-translations to drone.

@lafriks
Copy link
Member

lafriks commented Nov 1, 2017

I think it should be fixed in crowdin translations not in drone step...

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2017
@lunny
Copy link
Member Author

lunny commented Nov 1, 2017

I don't think so. Crowdin plugin is not only for Gitea A

@lafriks
Copy link
Member

lafriks commented Nov 1, 2017

There was also wrong translation in pt-BR, I already fixed that
LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2017
@appleboy
Copy link
Member

appleboy commented Nov 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2017
@lunny lunny merged commit de99150 into go-gitea:master Nov 1, 2017
@lunny lunny deleted the lunny/fix_translation branch November 1, 2017 12:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @lafriks @appleboy @jonasfranz @tboerger