Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object does not exist error when checking citation file #28314

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 1, 2023

Fix #28264

DataAsync() will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 1, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
@yp05327 yp05327 changed the title fix Fix object does not exist error when checking citation file Dec 1, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2023
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 type/bug labels Dec 1, 2023
@lunny lunny added this to the 1.22.0 milestone Dec 1, 2023
routers/web/repo/view.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Dec 5, 2023

Do we need to move break in to the if above which has been done in 05d9cff?

@wxiaoguang
Copy link
Contributor

Do we need to move break in to the if above which has been done in 05d9cff?

Either looks good to me (it doesn't matter too much IMO)

@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 5, 2023
@lunny lunny merged commit ec90ee6 into go-gitea:main Dec 6, 2023
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 6, 2023
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 6, 2023
@yp05327 yp05327 deleted the fix-28264 branch December 6, 2023 08:59
lunny pushed a commit that referenced this pull request Dec 6, 2023
…28369)

Backport #28314 by @yp05327

Fix #28264

`DataAsync()` will be called twice.
Caused by #27958.
I'm sorry, I didn't completely remove all unnecessary codes.

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 8, 2023
* giteaofficial/main:
  Improve text in Security settings (go-gitea#28393)
  Fix Docker meta action for releases (go-gitea#28232)
  Make gogit Repository.GetBranchNames consistent (go-gitea#28348)
  Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (go-gitea#28220)
  Include public repos in doer's dashboard for issue search (go-gitea#28304)
  Issue fixes for RSS feed improvements (go-gitea#28380)
  Fix margin in server signed signature verification view (go-gitea#28379)
  [skip ci] Updated translations via Crowdin
  Fix incorrect run order of action jobs (go-gitea#28367)
  Improve RSS feed icons (go-gitea#28368)
  Use `filepath` instead of `path` to create SQLite3 database file (go-gitea#28374)
  Fix incorrect default value of `[attachment].MAX_SIZE` (go-gitea#28373)
  Fix object does not exist error when checking citation file (go-gitea#28314)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…#28314)

Fix go-gitea#28264

`DataAsync()` will be called twice.
Caused by go-gitea#27958.
I'm sorry, I didn't completely remove all unnecessary codes.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkCitationFile() [E] GetBlobContent: object does not exist [id: cff-version:, rel_path: ]
5 participants