Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check online runner when detecting matching runners in workflows (#28286) #28512

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Only check online runner when detecting matching runners in workflows (#28286) #28512

merged 2 commits into from
Dec 19, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #28286 by @yp05327

Mentioned: #28277

We should only check online runner when detecting matching runners in workflows,
as if runner is not online, the workflow will not run.

image

@yp05327 @GiteaBot
Only check online runner when detecting matching runners in workflows (…
4a197e1 
…go-gitea#28286)

Mentioned:
[go-gitea#28277](go-gitea#28277 (comment))

We should only check online runner when detecting matching runners in
workflows,
as if runner is not online, the workflow will not run.


![image](https://github.com/go-gitea/gitea/assets/18380374/11855e9d-7241-4b7a-b8d7-49dbb94ba1c5)
@GiteaBot GiteaBot added this to the 1.21.3 milestone Dec 18, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2023
@lunny lunny enabled auto-merge (squash) December 19, 2023 03:33
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2023
@lunny lunny merged commit d9aeb1f into go-gitea:release/v1.21 Dec 19, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lunny lunny lunny approved these changes

@a1012112796 a1012112796 Awaiting requested review from a1012112796

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.3
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @appleboy @lunny @yp05327