Make offline mode as default to no connect external avatar service by default #28548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
added
the
pr/breaking
delvh
approved these changes
Dec 20, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Dec 20, 2023
GiteaBot
added
lgtm/done
pull-request-size
bot
added
size/S
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 22, 2023
* giteaofficial/main: Add more ways to try (go-gitea#28581) Convert to url auth to header auth in tests (go-gitea#28484) Fix 500 error of searching commits (go-gitea#28576) improve possible performance bottleneck (go-gitea#28547) Use information from previous blame parts (go-gitea#28572) Make offline mode as default to no connect external avatar service by default (go-gitea#28548) Fix merging artifact chunks error when minio storage basepath is set (go-gitea#28555) feat: bump `dessant/lock-threads` and `actions/setup-go` to use nodejs20 runtime (go-gitea#28565) Update actions document about comparsion as Github Actions (go-gitea#28560) Fix inperformant query on retrifing review from database. (go-gitea#28552) Fix the issue ref rendering for wiki (go-gitea#28556) Add missing head of lfs client batch (go-gitea#28550) [skip ci] Updated translations via Crowdin Remove deadcode under models/issues (go-gitea#28536) Always enable caches (go-gitea#28527) Improve ObjectFormat interface (go-gitea#28496)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
… default (go-gitea#28548) To keep user's privacy, make offline mode as true by default. Users can still change it from installation ui and app.ini
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
… default (go-gitea#28548) To keep user's privacy, make offline mode as true by default. Users can still change it from installation ui and app.ini
|
@lunny I have trouble understanding the impact on users. |
|
Some people worry that their computer/server's IP address will be collected by the Gravatar service which can be matched with the emails. Anyway, I personally don't think it's a big matter. And this PR will only make the offline mode default. People could still change offline mode to false if they would like. This PR should only affect those newly installed Gitea instances because once installed, the offline mode and the default value will be written to the app.ini. |
|
So in other words, this is basically not breaking but should only affect new instances in 99.95% of cases? |
lunny
removed
the
pr/breaking
GiteaBot
added
the
pr/breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep user's privacy, make offline mode as true by default.
Users can still change it from installation ui and app.ini
The setting
[server].OFFLINE_MODEis nowtrueby default.