Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary syncbranchToDB with tests (#28624) #28625

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary syncbranchToDB with tests (#28624) #28625

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Contributor

Backport #28624 by @lunny

#28361 introduced syncBranchToDB in CreateNewBranchFromCommit. This PR will revert the change because it's unnecessary. Every push will already be checked by syncBranchToDB.
This PR also created a test to ensure it's right.

@lunny @GiteaBot
Remove unnecessary syncbranchToDB with tests (go-gitea#28624)
05e7c0b 
go-gitea#28361 introduced `syncBranchToDB` in `CreateNewBranchFromCommit`. This
PR will revert the change because it's unnecessary. Every push will
already be checked by `syncBranchToDB`.
This PR also created a test to ensure it's right.
@GiteaBot GiteaBot added this to the 1.21.4 milestone Dec 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2023
@wxiaoguang
Copy link
Contributor

Need to fix some tests manually.

@lunny lunny mentioned this pull request Dec 28, 2023
Merged
@lunny
Copy link
Member

lunny commented Dec 28, 2023

replaced by #28629

@lunny lunny closed this Dec 28, 2023
@GiteaBot GiteaBot removed this from the 1.21.4 milestone Dec 28, 2023
@techknowlogick techknowlogick deleted the backport-28624-v1.21 branch December 28, 2023 13:57
lunny added a commit that referenced this pull request Dec 29, 2023
@lunny
Remove unnecessary syncbranchToDB with tests (#28624) (#28629)
ff565a7 
Replace #28625

Backport #28624 by lunny

#28361 introduced `syncBranchToDB` in `CreateNewBranchFromCommit`. This
PR will revert the change because it's unnecessary. Every push will
already be checked by `syncBranchToDB`.
This PR also created a test to ensure it's right.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees

@lunny lunny

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @wxiaoguang @lunny @wolfogre