Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty ref for cron workflow runs (#28640) #28647

Merged
merged 3 commits into from
Dec 29, 2023
Merged

fix empty ref for cron workflow runs (#28640) #28647

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f258f59
fix empty ref for cron workflow runs (#28640)
denyskon Dec 29, 2023
432d04b
Merge branch 'release/v1.21' into backport-28640-v1.21
GiteaBot Dec 29, 2023
b803347
Merge branch 'release/v1.21' into backport-28640-v1.21
GiteaBot Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/actions/notifier_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func notify(ctx context.Context, input *notifyInput) error {
}
}

if err := handleSchedules(ctx, schedules, commit, input); err != nil {
if err := handleSchedules(ctx, schedules, commit, input, ref); err != nil {
return err
}

Expand Down Expand Up @@ -373,6 +373,7 @@ func handleSchedules(
detectedWorkflows []*actions_module.DetectedWorkflow,
commit *git.Commit,
input *notifyInput,
ref string,
) error {
branch, err := commit.GetBranchName()
if err != nil {
Expand Down Expand Up @@ -422,7 +423,7 @@ func handleSchedules(
OwnerID: input.Repo.OwnerID,
WorkflowID: dwf.EntryName,
TriggerUserID: input.Doer.ID,
Ref: input.Ref,
Ref: ref,
CommitSHA: commit.ID.String(),
Event: input.Event,
EventPayload: string(p),
Expand Down