Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: missing refs/ in bare repositories #28844

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

AdamMajer
Copy link
Contributor

Git 2.43.0 will not detect a git repository as valid without refs/ subdirectory present. git gc cleans this up and puts it in packed-refs. We must keep refs/ non-empty.

Git 2.43.0 will not detect a git repository as valid without
refs/ subdirectory present. `git gc` cleans this up and puts it
in packed-refs. We must keep refs/ non-empty.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2024
@AdamMajer
Copy link
Contributor Author

for reference,
https://lore.kernel.org/git/20231117202513.20604-1-adamm@zombino.com/
https://lore.kernel.org/git/xmqqfs0c36fq.fsf@gitster.g/

The proposed fix here is very simple.

A better solution may be to add checks target that refs/ are not present in gitea repository (this would indicate that git gc was run) and in integration tests we can just re-create empty directories.

Preferred approach?

@AdamMajer AdamMajer changed the title Fix unit tests tests: missing refs/ in bare repositories Jan 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 18, 2024

Only this single repository is affected?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2024
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 type/testing reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 19, 2024
@lunny lunny merged commit 075c4c8 into go-gitea:main Jan 19, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 19, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 19, 2024
Git 2.43.0 will not detect a git repository as valid without refs/
subdirectory present. `git gc` cleans this up and puts it in
packed-refs. We must keep refs/ non-empty.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 19, 2024
lunny pushed a commit that referenced this pull request Jan 19, 2024
Backport #28844 by @AdamMajer

Git 2.43.0 will not detect a git repository as valid without refs/
subdirectory present. `git gc` cleans this up and puts it in
packed-refs. We must keep refs/ non-empty.

Co-authored-by: Adam Majer <amajer@suse.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 22, 2024
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Prevent anonymous container access if `RequireSignInView` is enabled (go-gitea#28877)
  Don't show new pr button when page is not compare pull (go-gitea#26431)
  Avoid duplicate JS error messages on UI (go-gitea#28873)
  Fix branch list bug which displayed default branch twice (go-gitea#28878)
  Revert adding htmx until we finaly decide to add it (go-gitea#28879)
  Don't do a full page load when clicking the follow button (go-gitea#28872)
  Don't do a full page load when clicking the subscribe button (go-gitea#28871)
  Fix incorrect PostgreSQL connection string for Unix sockets (go-gitea#28865)
  Run `npm audit fix` (go-gitea#28866)
  Fix migrate storage bug (go-gitea#28830)
  Set the `isPermaLink` attribute to `false` in the `guid` sub-element (go-gitea#28860)
  In administration documentation about environment variables, point to those for the Go runtime instead of Go compiler (go-gitea#28859)
  Move doctor package from modules to services (go-gitea#28856)
  Add support for sha256 repositories (go-gitea#23894)
  Fix incorrect action duration time when rerun the job before executed once (go-gitea#28364)
  Fix some RPM registry flaws (go-gitea#28782)
  tests: missing refs/ in bare repositories (go-gitea#28844)
  Fix archive creating LFS hooks and breaking pull requests (go-gitea#28848)
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
Git 2.43.0 will not detect a git repository as valid without refs/
subdirectory present. `git gc` cleans this up and puts it in
packed-refs. We must keep refs/ non-empty.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Git 2.43.0 will not detect a git repository as valid without refs/
subdirectory present. `git gc` cleans this up and puts it in
packed-refs. We must keep refs/ non-empty.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants