Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded GitHub icon used as migrated release avatar #28910

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Jan 24, 2024

Unhardcodes the avatar of migrated release authors from "octicon-mark-github" to the host-specific one provided by MigrationIcon.

Preview

With my repository imported from GitLab.

Before

Release with GitHub icon as avatar

After

Release with generic Git icon as avatar

Unhardcodes the avatar of migrated release authors from `"octicon-mark-github"` to the host-specific one provided by `MigrationIcon`.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 24, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2024
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 24, 2024
@jolheiser jolheiser enabled auto-merge (squash) January 24, 2024 00:34
@jolheiser jolheiser merged commit fd97613 into go-gitea:main Jan 24, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 24, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 24, 2024
@wackbyte wackbyte deleted the releases-use-migration-icon branch January 24, 2024 01:09
@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jan 24, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 25, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Show in Web UI if file is vendored and generated (go-gitea#28620)
  Don't reload timeline page when (un)resolving or replying conversation (go-gitea#28654)
  Allow to sync tags from admin dashboard (go-gitea#28045)
  Don't run push mirrors for archived repos (go-gitea#27140)
  Only migrate the first 255 chars of a Github issue title (go-gitea#28902)
  Fix hardcoded GitHub icon used as migrated release avatar (go-gitea#28910)
  [skip ci] Updated translations via Crowdin
  Update go dependencies and fix go-git (go-gitea#28893)
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants