Fix issue link rendering in commit messages #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
force-pushed
the
fix/commit_msg
branch
from
b41fa49
to
2d11815
Compare
ethantkoenig
force-pushed
the
fix/commit_msg
branch
from
2d11815
to
824cf3b
Compare
ethantkoenig
commented
Nov 12, 2017
| @@ -252,28 +253,27 @@ func ReplaceLeft(s, old, new string) string { | |||
| } | |||
|
|
|||
| // RenderCommitMessage renders commit message with XSS-safe and special links. | |||
| func RenderCommitMessage(full bool, msg, urlPrefix string, metas map[string]string) template.HTML { | |||
| func RenderCommitMessage(msg, urlPrefix string, metas map[string]string) template.HTML { | |||
There was a problem hiding this comment.
I removed the full parameter, because it was always set to false.
Codecov Report
@@ Coverage Diff @@
## master #2897 +/- ##
=========================================
+ Coverage 26.85% 27% +0.15%
=========================================
Files 89 89
Lines 17607 17644 +37
=========================================
+ Hits 4728 4765 +37
Misses 12193 12193
Partials 686 686
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
|
|
@lunny fixed |
|
@ethantkoenig is it possible to add so that brackets that are around issue/pr number are not added to commit link? |
|
@lafriks Should be doable |
|
Like in @lunny screenshot in issue. It would look much better if brackets would not be part of any link |
|
@lafriks Done |
lafriks
approved these changes
Nov 12, 2017
|
Nice, LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2870.