Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include username in email headers #28981

Merged
merged 3 commits into from
Feb 3, 2024

Commits on Jan 31, 2024

  1. Include username in email headers

    Emails from Gitea comments do not contain the username of the commenter
    anywhere, only their display name, so it is not possible to verify who
    made a comment from the email itself:
    
    	From: "Alice" <email@gitea>
    	X-Gitea-Sender: Alice
    	X-Gitea-Recipient: Bob
    	X-GitHub-Sender: Alice
    	X-GitHub-Recipient: Bob
    
    	This comment looks like it's from @alice.
    
    The X-Gitea/X-GitHub headers also use display names, which is not very
    reliable for filtering, and inconsistent with GitHub's behavior:
    
    	X-GitHub-Sender: lunny
    	X-GitHub-Recipient: gwymor
    
    This change includes both the display name and username in the From
    header, and switches the other headers from display name to username:
    
    	From: "Alice (@fakeAlice)" <email@gitea>
    	X-Gitea-Sender: fakealice
    	X-Gitea-Recipient: bob
    	X-GitHub-Sender: fakealice
    	X-GitHub-Recipient: bob
    
    	This comment looks like it's from @alice.
    gwymor committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6d8f2e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d96745 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Configuration menu
    Copy the full SHA
    3247ee2 View commit details
    Browse the repository at this point in the history