Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google logo in security page #28982

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix google logo in security page #28982

merged 1 commit into from
Jan 30, 2024

Conversation

Sirherobrine23
Copy link
Contributor

Fix google logo in user security page: #28701

Before

before user security page

after

user security page

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2024
@lafriks
Copy link
Member

lafriks commented Jan 30, 2024

SVG file needs to be formatted

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2024
@silverwind
Copy link
Member

SVG file needs to be formatted

You mean pretty-printed? I'd classify that as optional for the file in web_src.

@lafriks lafriks merged commit 37ede31 into go-gitea:main Jan 30, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 30, 2024
@Sirherobrine23
Copy link
Contributor Author

SVG file needs to be formatted

I've never used SVG, I wanted to understand a little, I got the base from Google fonts file and added class to file, and after changing SVG to this pull, google logo fixed in settings page

@lafriks
Copy link
Member

lafriks commented Jan 30, 2024

SVG file needs to be formatted

You mean pretty-printed? I'd classify that as optional for the file in web_src.

no it was before force push

@Sirherobrine23
Copy link
Contributor Author

Oh, ok, thanks to merge

henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 1, 2024
* origin/main:
  [skip ci] Updated translations via Crowdin
  Fix UI Spacing Errors in mirror settings (go-gitea#28990)
  Add htmx guidelines (go-gitea#28993)
  Some refactor for git http (go-gitea#28995)
  Fix an actions schedule bug (go-gitea#28942)
  Fix doc img path in profile readme (go-gitea#28994)
  Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (go-gitea#28908)
  Fix joins in `db.Find(AndCount)` (go-gitea#28978)
  Update golang links to use https (go-gitea#28980)
  Fix google logo in security page (go-gitea#28982)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 1, 2024
* giteaofficial/main:
  Revert "Speed up loading the dashboard on mysql/mariadb (go-gitea#28546)" (go-gitea#29006)
  Update dorny/paths-filter action (go-gitea#29003)
  [skip ci] Updated translations via Crowdin
  Fix UI Spacing Errors in mirror settings (go-gitea#28990)
  Add htmx guidelines (go-gitea#28993)
  Some refactor for git http (go-gitea#28995)
  Fix an actions schedule bug (go-gitea#28942)
  Fix doc img path in profile readme (go-gitea#28994)
  Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (go-gitea#28908)
  Fix joins in `db.Find(AndCount)` (go-gitea#28978)
  Update golang links to use https (go-gitea#28980)
  Fix google logo in security page (go-gitea#28982)
  Also match weakly validated ETags (go-gitea#28957)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants