-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swagger documentation #2899
Conversation
Add docs for missing endpoints Add documentation for request parameters Make parameter naming consistent Fix response documentation
24c1a0e
to
d4e9781
Compare
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 27% 27.05% +0.04%
==========================================
Files 89 89
Lines 17644 17650 +6
==========================================
+ Hits 4765 4775 +10
+ Misses 12193 12189 -4
Partials 686 686
Continue to review full report at Codecov.
|
routers/api/v1/api.go
Outdated
@@ -1,15 +1,7 @@ | |||
// Copyright 2015 The Gogs Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you remove copyrigths ? We could add gitea ones ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed
routers/api/v1/api.go
Outdated
// license that can be found in the LICENSE file. | ||
|
||
// Package v1 Gitea API. | ||
// | ||
// This provide API interface to communicate with this Gitea instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you remove the description ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed
Two little comments that should be fixed. For the rest LGTM. Thanks for doing it, it takes time and few good catch like https://github.com/go-gitea/gitea/pull/2899/files#diff-2620fdbeeb83ce43692534e6c2c39452R315. |
@sapk Fixed. The "Terms of Service" link doesn't work, so that is still removed, everything else is restored. |
Fixes #2635. This PR fixes the following:
This PR has no functional change.