Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in user settings UI #2901

Merged
merged 2 commits into from
Nov 13, 2017

Conversation

efy
Copy link
Contributor

@efy efy commented Nov 12, 2017

This PR cleans up a couple of UI items in the user settings panel.

Field length and button / link alignment on the delete account tab, think this fixes #1659.

Old:
image

New:
image

Un-styled input on the OpenID tab

Old:
image

New:
image

@codecov-io
Copy link

codecov-io commented Nov 12, 2017

Codecov Report

Merging #2901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2901   +/-   ##
=======================================
  Coverage   27.05%   27.05%           
=======================================
  Files          89       89           
  Lines       17650    17650           
=======================================
  Hits         4775     4775           
  Misses      12189    12189           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26f4a7...6ba2434. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2017
@lafriks
Copy link
Member

lafriks commented Nov 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 12, 2017
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 12, 2017
@lafriks lafriks added this to the 1.x.x milestone Nov 12, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2017
@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Nov 13, 2017
@lafriks lafriks merged commit 4725f91 into go-gitea:master Nov 13, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete account password field length
5 participants