Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless template file #29053

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Remove useless template file #29053

merged 3 commits into from
Feb 5, 2024

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Feb 5, 2024

Removed templates/repo/settings/nav.tmpl.

I don't think it's still used.

On main branch:
image

On commit 755eec7 (the commit that created this file):

image

@wolfogre wolfogre added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 5, 2024
@wolfogre wolfogre added this to the 1.22.0 milestone Feb 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 5, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2024
@lunny lunny enabled auto-merge (squash) February 5, 2024 08:55
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 5, 2024
@lunny lunny merged commit 0d136df into go-gitea:main Feb 5, 2024
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 7, 2024
* giteaofficial/main:
  Hide code links on release page if user cannot read code (go-gitea#29064)
  [skip ci] Updated translations via Crowdin
  Don't do a full page load when clicking `Watch` or `Star` (go-gitea#29001)
  Remove useless template file (go-gitea#29053)
  Fix typos in the documentation (go-gitea#29048)
  Move some repository transfer functions to service layer (go-gitea#28855)
  Propagate install_if and provider_priority to APKINDEX (go-gitea#28899)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Removed `templates/repo/settings/nav.tmpl`.

I don't think it's still used.

On main branch:
<img width="521" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/c0bf958c-698a-4348-840e-3ade0312bd6e">

On commit 755eec7 (the commit that
created this file):

<img width="615" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/5156b26d-1ecd-4197-a0a6-dc2d17652ff4">
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants