Remove jQuery from the "quick submit" handler #29200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched to plain JavaScript - Tested the quick submit functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
yardenshoham
added
the
type/refactoring
github-actions
bot
added
modifies/frontend
and removed
type/refactoring
yardenshoham
added
the
type/refactoring
silverwind
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 16, 2024
wxiaoguang
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Feb 16, 2024
GiteaBot
added
lgtm/done
|
Hope you tested it 😆 |
wxiaoguang
reviewed
Feb 16, 2024
| @@ -8,7 +8,7 @@ export function handleGlobalEnterQuickSubmit(target) { | |||
|
|
|||
| // here use the event to trigger the submit event (instead of calling `submit()` method directly) | |||
| // otherwise the `areYouSure` handler won't be executed, then there will be an annoying "confirm to leave" dialog | |||
| form.dispatchEvent(new SubmitEvent('submit', {bubbles: true, cancelable: true})); | |||
| form.dispatchEvent(new SubmitEvent('submit')); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, but does that also apply to SubmitEvent? Neither MDN nor the HTML spec seem to give an answer, so we may need to test it. Might also be good to check what jQuery did internally and just do that.
GiteaBot
added
lgtm/need 1
This reverts commit cf8d365.
wxiaoguang
approved these changes
Feb 16, 2024
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
delvh
approved these changes
Feb 16, 2024
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Feb 18, 2024
…o-gitea#29223) Partially related to go-gitea#29200 and fix other potential bugs. Co-authored-by: Giteabot <teabot@gitea.io>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Switched to plain JavaScript - Tested the quick submit functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…o-gitea#29223) Partially related to go-gitea#29200 and fix other potential bugs. Co-authored-by: Giteabot <teabot@gitea.io>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Switched to plain JavaScript - Tested the quick submit functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> (cherry picked from commit d8d4b33)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using JavaScript without jQuery