Remove jQuery from the webhook editor #29211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched to plain JavaScript - Tested the webhook editing functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
yardenshoham
added
the
type/refactoring
6543
approved these changes
Feb 17, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 17, 2024
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
approved these changes
Feb 17, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 18, 2024
* giteaofficial/main: (28 commits) Improve TrHTML and add more tests (go-gitea#29228) Convert visibility to number (go-gitea#29226) Implement some action notifier functions (go-gitea#29173) Artifact deletion in actions ui (go-gitea#27172) Update docs for actions variables (go-gitea#29239) Refactor more code in templates (go-gitea#29236) Use "Safe" modifier for manually constructed safe HTML strings in templates (go-gitea#29227) Remove jQuery from the repo release form (go-gitea#29225) Make submit event code work with both jQuery event and native event (go-gitea#29223) Remove jQuery from repo migrate page (go-gitea#29219) Remove unneccesary `initUserAuthLinkAccountView` from "link account" page (go-gitea#29217) Fix labels referencing the wrong ID in the user profile settings (go-gitea#29199) Fix label `for` pointing to a `name` instead of `id` in webhook settings (go-gitea#29209) Load outdated comments when (un)resolving conversation on PR timeline (go-gitea#29203) Fix missing template for follow button in organization (go-gitea#29215) Enable markdownlint `no-trailing-punctuation` and `no-blanks-blockquote` (go-gitea#29214) Remove jQuery from the webhook editor (go-gitea#29211) Remove jQuery from issue reference context popup attach (go-gitea#29216) fix typo (go-gitea#29212) Fix debian InRelease Acquire-By-Hash newline (go-gitea#29204) ...
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
- Switched to plain JavaScript - Tested the webhook editing functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Switched to plain JavaScript - Tested the webhook editing functionality and it works as before # Demo using JavaScript without jQuery  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit 27192bc)
|
Automatically locked because of our CONTRIBUTING guidelines |
Merged
wxiaoguang
reviewed
Mar 9, 2024
|
|
||
| const updateContentType = function () { | ||
| const visible = $('#http_method').val() === 'POST'; | ||
| toggleElem($('#content_type').parent().parent(), visible); | ||
| const visible = document.getElementById('http_method').value === 'POST'; |
There was a problem hiding this comment.
Regression:
WebHookEditor.js:26 Uncaught TypeError: Cannot read properties of null (reading 'value')
at updateContentType (WebHookEditor.js:26:58)
at initCompWebHookEditor (WebHookEditor.js:29:3)
at HTMLDocument.<anonymous> (index.js:109:24)
const updateContentType = function () {
const visible = document.getElementById('http_method').value === 'POST'; // <--------- HERE
toggleElem(document.getElementById('content_type').parentNode.parentNode, visible);
};
http_method may not exist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using JavaScript without jQuery