-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optional.Option[T] type serializable #29282
Conversation
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
This PR should be merged first then #29329 |
They are related but independent :) As the changed struct in mentioned pull are not used for de-/serializion |
PS: I'm happy to see it merged once it has sufficient reviews ;) |
When I added the option type I had a look at the chi binding which is needed for form binding but that looked more complicated. But we should add support there too before we start to use the option type in forms. |
@KN4CK3R yes but that's outside of this pull scope i would say ? |
yes, just want to share my thoughts. |
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
PS: |
It is identical. |
make the generic
Option
type de-/serializable for json and yaml