Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user-defined markup links targets #29305

Merged
merged 11 commits into from
Mar 8, 2024
Merged

Fix user-defined markup links targets #29305

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59565d0
Changed file anchor.js to fix the bug in issue #29196
DanielMatiasCarvalho Feb 20, 2024
cbd3865
Merge branch 'go-gitea:main' into issue-29196
DanielMatiasCarvalho Feb 21, 2024
9d86a63
Refactor the code
DanielMatiasCarvalho Feb 22, 2024
8a7e2bd
Merge branch 'issue-29196' of https://github.com/DanielMatiasCarvalho…
DanielMatiasCarvalho Feb 22, 2024
c8dcd5b
Merge branch 'main' into issue-29196
silverwind Mar 5, 2024
34f7e91
add comments, style tweaks
silverwind Mar 5, 2024
af2a153
Merge branch 'main' into issue-29196
silverwind Mar 7, 2024
02d3ae8
Implemented the recommended changes in the Pull Request
DanielMatiasCarvalho Mar 7, 2024
302952a
Merge branch 'main' into issue-29196
GiteaBot Mar 8, 2024
7a72b49
Merge branch 'main' into issue-29196
GiteaBot Mar 8, 2024
93075cb
Merge branch 'main' into issue-29196
GiteaBot Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions web_src/js/markup/anchors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,20 @@ export function initMarkupAnchors() {
});
heading.prepend(a);
}
for (const anchor of document.querySelectorAll('.markup [dir="auto"] > a[href^="#"][rel="nofollow"]')) {
DanielMatiasCarvalho marked this conversation as resolved.
Show resolved Hide resolved
const originalId = anchor.getAttribute('href').replace(/^#user-content-/, '');
DanielMatiasCarvalho marked this conversation as resolved.
Show resolved Hide resolved
anchor.setAttribute('href', `#${encodeURIComponent(originalId)}`);
const anchorDest = document.getElementsByName(originalId);
if (anchorDest && anchorDest.length === 1) {
DanielMatiasCarvalho marked this conversation as resolved.
Show resolved Hide resolved
anchor.addEventListener('click', () => {
anchorDest[0].scrollIntoView();
});
} else {
anchor.addEventListener('click', (e) => {
scrollToAnchor(e.currentTarget.getAttribute('href'), false);
});
}
}

scrollToAnchor(window.location.hash, true);
}
Loading