Update FAQ about git hook problems #29495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
type/docs
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
delvh
approved these changes
Feb 29, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 29, 2024
GiteaBot
added
lgtm/done
KN4CK3R
approved these changes
Feb 29, 2024
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 29, 2024
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Feb 29, 2024
Backport #29495 by @wolfogre Close #29338 (comment) Co-authored-by: Jason Song <i@wolfogre.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 1, 2024
* giteaofficial/main: Don’t comment when locking (go-gitea#29508) [skip ci] Updated translations via Crowdin migrate some more "OptionalBool" to "Option[bool]" (go-gitea#29479) Update FAQ about git hook problems (go-gitea#29495)
silverwind
pushed a commit
that referenced
this pull request
Mar 6, 2024
Detect broken git hooks by checking if the commit id of branches in DB is the same with the git repo. It can help #29338 #28277 and maybe more issues. Users could complain about actions, webhooks, and activities not working, but they were not aware that it is caused by broken git hooks unless they could see a warning. <img width="1348" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/2b92a46d-7f1d-4115-bef4-9f970bd695da"> It should be merged after #29493. Otherwise, users could see a ephemeral warning after committing and opening the repo home page immediately. And it also waits for #29495, since the doc link (the anchor part) will be updated. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #29338 (comment)