Fix DEFAULT_SHOW_FULL_NAME=false has no effect in commit list and commit graph page

[yp05327]

Fix #20446

This PR will fix the username in:
repo home page

repo commit list page

repo commit graph page

pr commit page

Will not fix:
wiki revisions page:

ps: the author name is FullName by default

[delvh]

Wait… DEFAULT_SHOW_FULL_NAME is used as ENABLE_SHOW_FULL_NAME?
Sounds a bit weird to me.

[delvh]

Do we need to rename the config key?
Or how should we handle that?

[wxiaoguang]

Do we need to rename the config key? Or how should we handle that?

The "user name" display needs a complete rewriting. IMO it could be used by 3 methods:

1. UserName
2. GetDisplayNameFull():
   • If DEFAULT_SHOW_FULL_NAME == true:
     • UserName if FullName is empty; UserName (FullName) if FullName is not empty
   • If DEFAULT_SHOW_FULL_NAME == false:
     • UserName
3. GetDisplayNameShort():
   • UserName if FullName is empty; FullName if FullName is not empty
   • Actually I think this case should be avoided for most cases, it only cause confusing.

[silverwind]

Yes, it does sound like this logic belongs in Go, not in the templates. But I guess I would accept current patch too as a short-term measure.

[yp05327]

Actually, we already have a function (same to GetDisplayNameFull mentioned above ) for User:

I'm confuseing which one to use, commit.Author.Name/FullName or commit.User.Name/FullName

[techknowlogick]

I agree with others that this is a suitable interim approach