Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action view mobile improvements and fixes (#30309) #30320

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 7, 2024

Backport #30309 by @silverwind

Fix the action issue in #30303, specifically:

  • Use opaque step header hover background to avoid transparency issue
  • Un-sticky the action-view-left on mobile, it would otherwise overlap into right view
  • Improve commit summary, let it wrap
  • Fix and comment z-indexes
  • Tweak width for run-list-item-right so it wastes less space on desktop
  • Synced latest changes to console colors from dark to light theme
Screenshot 2024-04-06 at 18 58 15

Fix the action issue in go-gitea#30303,
specifically:

- Use opaque step header hover background to avoid transparency issue
- Un-sticky the `action-view-left` on mobile, it would otherwise overlap
into right view
- Improve commit summary, let it wrap
- Fix and comment z-indexes
- Tweak width for run-list-item-right so it wastes less space on desktop
- Synced latest changes to console colors from dark to light theme

<img width="467" alt="Screenshot 2024-04-06 at 18 58 15"
src="https://github.com/go-gitea/gitea/assets/115237/8ad26b72-6cd9-4522-8ad1-6fd86b2d0d53">
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 7, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 7, 2024
@GiteaBot GiteaBot requested review from delvh and lunny April 7, 2024 12:41
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2024
@silverwind silverwind enabled auto-merge (squash) April 7, 2024 15:17
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2024
@silverwind silverwind merged commit 10d83ae into go-gitea:release/v1.22 Apr 7, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 7, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants