-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few root files to lint-spell #30530
Conversation
Changed entry in |
Should we spellcheck CHANGELOG.md or do we consider it append-only? I'd say yes, we can change it. |
I agree |
Applied to changelog as well now and ran |
Ideally there would be a way to also lint the PR title during PR checks, not sure how to do it though, at least not without a temp file and then there's the issue that CI does not run after commit title change. |
New @GiteaBot functionality? 🤔 |
Likely will be hard to run the go-based spellchecker in the bot which is typescript. If it can run the go checker, then it would likely be as simple as writ the string to a file, run on that and check the exit code. cc: @yardenshoham. |
hmmmm, maybe with https://www.npmjs.com/package/cspell |
I think I may actually exclude changelog again because I don't want to put the burden onto the releaser to fix typos that they haven't made. |
On topic: https://github.com/crate-ci/typos looks interesting, but it's rust which we have not integrated yet as tooling language. |
CHANGELOG.md is excluded again. I think we can at least keep the typo fixes in it, so it's a one-time correction basically. The |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Mock queue backoff duration (go-gitea#30553) Improve "Reference in new issue" modal (go-gitea#30547) Add a few root files to lint-spell (go-gitea#30530) Refactor and fix archive link bug (go-gitea#30535) Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555) Some following up changes for routes (go-gitea#30550) Add form field id generation, remove duplicated ids (go-gitea#30546) Fix border-radius on view, blame and code search (go-gitea#30545) Disable enter key for accepting code completion in Monaco (go-gitea#30548)
Files in root were not linted, add them. No new violations.