Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few root files to lint-spell #30530

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

silverwind
Copy link
Member

Files in root were not linted, add them. No new violations.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 17, 2024
Makefile Outdated Show resolved Hide resolved
@silverwind
Copy link
Member Author

silverwind commented Apr 17, 2024

Changed entry in ESLINT_FILES to *.js to match.

@silverwind
Copy link
Member Author

silverwind commented Apr 17, 2024

Should we spellcheck CHANGELOG.md or do we consider it append-only? I'd say yes, we can change it.

@techknowlogick
Copy link
Member

I'd say yes, we can change it.

I agree

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@silverwind
Copy link
Member Author

Applied to changelog as well now and ran make lint-spell-fix. Also the wildcard is removed, which will give better Makefile performance.

@silverwind
Copy link
Member Author

silverwind commented Apr 17, 2024

Ideally there would be a way to also lint the PR title during PR checks, not sure how to do it though, at least not without a temp file and then there's the issue that CI does not run after commit title change.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2024
@techknowlogick
Copy link
Member

Ideally there would be a way to also lint the PR title during PR checks, not sure how to do it though, at least not without a temp file and then there's the issue that CI does not run after commit title change.

New @GiteaBot functionality? 🤔

@silverwind
Copy link
Member Author

silverwind commented Apr 17, 2024

Ideally there would be a way to also lint the PR title during PR checks, not sure how to do it though, at least not without a temp file and then there's the issue that CI does not run after commit title change.

New @GiteaBot functionality? 🤔

Likely will be hard to run the go-based spellchecker in the bot which is typescript. If it can run the go checker, then it would likely be as simple as writ the string to a file, run on that and check the exit code.

cc: @yardenshoham.

@yardenshoham
Copy link
Member

hmmmm, maybe with https://www.npmjs.com/package/cspell

@silverwind
Copy link
Member Author

I think I may actually exclude changelog again because I don't want to put the burden onto the releaser to fix typos that they haven't made.

@silverwind silverwind marked this pull request as draft April 18, 2024 08:14
@silverwind
Copy link
Member Author

hmmmm, maybe with https://www.npmjs.com/package/cspell

On topic: https://github.com/crate-ci/typos looks interesting, but it's rust which we have not integrated yet as tooling language.

@silverwind
Copy link
Member Author

CHANGELOG.md is excluded again. I think we can at least keep the typo fixes in it, so it's a one-time correction basically. The wildcard does not seem to have any impact on Makefile performance, so I kept it.

@silverwind silverwind marked this pull request as ready for review April 18, 2024 18:28
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
@silverwind silverwind enabled auto-merge (squash) April 18, 2024 18:28
@silverwind silverwind merged commit 3547054 into go-gitea:main Apr 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 18, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 19, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Mock queue backoff duration (go-gitea#30553)
  Improve "Reference in new issue" modal (go-gitea#30547)
  Add a few root files to lint-spell (go-gitea#30530)
  Refactor and fix archive link bug (go-gitea#30535)
  Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555)
  Some following up changes for routes (go-gitea#30550)
  Add form field id generation, remove duplicated ids (go-gitea#30546)
  Fix border-radius on view, blame and code search (go-gitea#30545)
  Disable enter key for accepting code completion in Monaco (go-gitea#30548)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants