Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify mirror repository API logic #30963

Merged
merged 2 commits into from
May 17, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30921

Some clients keeps sending EnablePrune=false to the server, so old code would always fail for non-mirror repositories.

Actually, reporting a lot of errors doesn't really help end users. It could simply skip the update if the repo is not a mirror.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 13, 2024
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 17, 2024 15:41
@wxiaoguang wxiaoguang merged commit 821d2fc into go-gitea:main May 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 17, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 17, 2024
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 17, 2024
@wxiaoguang wxiaoguang deleted the fix-api-mirror branch May 17, 2024 16:10
wxiaoguang added a commit that referenced this pull request May 18, 2024
Backport #30963 by wxiaoguang

Fix #30921

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 20, 2024
* giteaofficial/main:
  Fix "force private" logic (go-gitea#31012)
  [skip ci] Updated licenses and gitignores
  Improve reverse proxy documents and clarify the AppURL guessing behavior (go-gitea#31003)
  Fix bug on avatar (go-gitea#31008)
  Clean up revive linter config, tweak golangci output (go-gitea#30980)
  Simplify mirror repository API logic (go-gitea#30963)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RepoEdit via API fails with "repo is not a mirror, can not change mirror interval"
4 participants