Add nix flake for dev shell #30967
Merged
Add nix flake for dev shell #30967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To try it you need **nix** installed `nix-daemon ` running and your user has to be member of the **nix-users** group. Or use NixOS. then by just: ```sh nix develop -c $SHELL ``` a dedicated development environment with all needed packages will be created.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
|
This may as well just use eachDefaultSystem |
jolheiser
reviewed
May 13, 2024
|
we might also consider devbox, as we are already using it for tea https://gitea.com/gitea/tea/pulls/572 |
pull-request-size
bot
added
size/M
|
it looks like devbox use nix anyway ?!? |
jolheiser
reviewed
May 13, 2024
There was a problem hiding this comment.
it looks like devbox use nix anyway ?!?
Yeah, it uses nix under the hood. As mentioned in that PR, it may (or may not) be beneficial for non-nix users as it abstracts over nix.
(I have no real preference, also as noted in that PR I'm more comfortable with nix than devbox so it's 🤷 to me)
6543
commented
May 13, 2024
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
jolheiser
reviewed
May 13, 2024
jolheiser
approved these changes
May 13, 2024
GiteaBot
added
lgtm/need 1
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
silverwind
reviewed
May 13, 2024
6543
commented
May 14, 2024
I'm happy to have them there as long as they are versioned. Unversioned is a problem. Ideally all dependencies should be versioned. |
|
Some more ideas based on stuff in makefile:
|
jolheiser
reviewed
May 15, 2024
|
I'm happy that nix support for local dev is going in, so I won't block if it remains different than tea. |
jolheiser
reviewed
May 16, 2024
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
|
Do we need to regenerate |
silverwind
reviewed
May 16, 2024
No |
silverwind
approved these changes
May 21, 2024
GiteaBot
added
lgtm/done
jolheiser
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 22, 2024
* giteaofficial/main: Add nix flake for dev shell (go-gitea#30967) [skip ci] Updated translations via Crowdin Fix wrong display of recently pushed notification (go-gitea#25812) use existing oauth grant for public client (go-gitea#31015) Fix automerge will not work because of some events haven't been triggered (go-gitea#30780)
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jun 10, 2024
To try it you need **nix** installed `nix-daemon ` running and your user has to be member of the **nix-users** group. Or use NixOS. then by just: ```sh nix develop -c $SHELL ``` a dedicated development environment with all needed packages will be created.
6543
added
backport/v1.22
|
_> #31310 |
lunny
pushed a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try it you need nix installed
nix-daemonrunning and your user has to be member of the nix-users group. Or use NixOS.then by just:
nix develop -c $SHELLa dedicated development environment with all needed packages will be created.