Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double border in system status table (#31363) #31401

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix double border in system status table (#31363) #31401

merged 1 commit into from
Jun 17, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #31363 by @silverwind

Fix regression from #30712 where the introduction of this <div> caused the .ui.attached:not(.message) + .ui.attached.segment:not(.top) CSS selector to no longer work and cause a double border.

Before:

Screenshot 2024-06-13 at 19 06 12

After:
Screenshot 2024-06-13 at 19 05 57

@silverwind @wxiaoguang @GiteaBot
Fix double border in system status table (go-gitea#31363)
751e618 
Fix regression from go-gitea#30712 where
the introduction of this `<div>` caused the `.ui.attached:not(.message)
+ .ui.attached.segment:not(.top)` CSS selector to no longer work and
cause a double border.

Before:

<img width="200" alt="Screenshot 2024-06-13 at 19 06 12"
src="https://github.com/go-gitea/gitea/assets/115237/a9fa0688-adf0-4b2d-a958-6a7679a62031">

After:
<img width="232" alt="Screenshot 2024-06-13 at 19 05 57"
src="https://github.com/go-gitea/gitea/assets/115237/025b780f-f72f-4049-86de-a5d84851bd1d">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the modifies/templates This PR modifies the template files label Jun 17, 2024
@GiteaBot GiteaBot added this to the 1.22.1 milestone Jun 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2024
@wxiaoguang wxiaoguang merged commit e8e43a7 into go-gitea:release/v1.22 Jun 17, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh Awaiting requested review from delvh

@yardenshoham yardenshoham Awaiting requested review from yardenshoham

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @silverwind @wxiaoguang