Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor webhook #31587

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Refactor webhook #31587

merged 2 commits into from
Jul 10, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 8, 2024 •
edited
Loading

A more complete fix for #31588

  1. Make "generic" code more readable
  2. Clarify HTML or Markdown for the payload content

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 8, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jul 8, 2024
Merged
@wxiaoguang wxiaoguang force-pushed the refactor-webhook branch 10 times, most recently from 1ca153b to 948ba3d Compare July 8, 2024 07:27
@wxiaoguang wxiaoguang mentioned this pull request Jul 8, 2024
Merged
@wxiaoguang wxiaoguang mentioned this pull request Jul 8, 2024
Merged
@lunny lunny added this to the 1.23.0 milestone Jul 9, 2024
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 10, 2024 11:07
@wxiaoguang wxiaoguang merged commit 72b6bc8 into go-gitea:main Jul 10, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-webhook branch July 10, 2024 12:04
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
30278e0 
* giteaofficial/main:
  Upgrade security public key (go-gitea#31594)
  Fix wrong merge on removing docs (go-gitea#31605)
  Refactor webhook (go-gitea#31587)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot