Add test for only non-master branch repo view #3190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
force-pushed
the
lunny/fix_non_master
branch
from
34f346b
to
29a6090
Compare
|
depend on go-gitea/git#98 |
tboerger
added
the
lgtm/need 2
|
also fix #3202 |
|
And the error is still copy git vendor checksum error. |
|
It's unnecessary to back port since #3204 didn't report 500. |
ethantkoenig
suggested changes
Dec 18, 2017
| @@ -67,3 +67,46 @@ | |||
| type: 5 | |||
| config: "{}" | |||
| created_unix: 946684810 | |||
|
|
|||
There was a problem hiding this comment.
nit: please remove extra line this has been fixed, but the other blank line was removed, so the comment persists
integrations/links_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestRepoLinksNoLogin(t *testing.T) { |
There was a problem hiding this comment.
Please add to the existing test in integrations/repo_test.go, instead of creating a duplicate.
appleboy
added a commit
to appleboy/gitea
that referenced
this pull request
Dec 20, 2017
lunny
pushed a commit
that referenced
this pull request
Dec 20, 2017
lunny
changed the title
lunny
force-pushed
the
lunny/fix_non_master
branch
from
ef52192
to
aeee98f
Compare
|
What's up with this PR @lunny ? Can you fix Drone ? |
ethantkoenig
approved these changes
Jan 8, 2018
integrations/repo_test.go
Outdated
| @@ -74,3 +75,26 @@ func TestViewRepo1CloneLinkAuthorized(t *testing.T) { | |||
| sshURL := fmt.Sprintf("%s@%s:user2/repo1.git", setting.RunUser, setting.SSH.Domain) | |||
| assert.Equal(t, sshURL, link) | |||
| } | |||
|
|
|||
| func testRepoLinksNoLogin(repoPath string, t *testing.T) { | |||
There was a problem hiding this comment.
It would be nice to combine these tests with the existing tests above, but perhaps that can be a separate PR.
tboerger
added
lgtm/need 1
lunny
force-pushed
the
lunny/fix_non_master
branch
from
a117c58
to
168b164
Compare
|
closed by #3715 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title and will fix #3181