Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support workflow event dispatch via API #32059

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Feature: Support workflow event dispatch via API #32059

wants to merge 17 commits into from
+999 −0

Conversation

bencurio
Copy link

@bencurio bencurio commented Sep 17, 2024 •
edited
Loading

ref: #31765

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 17, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Sep 17, 2024
techknowlogick and others added 7 commits September 18, 2024 10:42
@techknowlogick
re-arrange imports
554de04
@techknowlogick
remove extra empty line
ccfbdaf
@techknowlogick
make fmt
1fae9c8
@bencurio
Feature: Support workflow event dispatch via API
a4dfa0b 
Signed-off-by: Bence Santha <git@santha.eu>
@bencurio
Resolve conflict
ea12e16 
Signed-off-by: Bence Santha <git@santha.eu>
@bencurio
removed unused imports
b525269 
Signed-off-by: Bence Santha <git@santha.eu>
@bencurio
adding more fields to the workflow list output
6f1b199 
Signed-off-by: Bence Santha <git@santha.eu>
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2024
bencurio and others added 4 commits September 20, 2024 14:15
@bencurio
Merge remote-tracking branch 'upstream/main'
35bb7e7
@bencurio
refactor
27d1906 
Signed-off-by: Bence Santha <git@santha.eu>
@bencurio
Merge branch 'main' into main
e67b371
@bencurio
updated swagger spec
a983e12 
Signed-off-by: Bence Santha <git@santha.eu>
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2024
@bencurio
refactor
8883fad 
Signed-off-by: Bence Santha <git@santha.eu>
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2024
@bencurio bencurio marked this pull request as ready for review October 2, 2024 10:18
@bencurio bencurio changed the title [WIP] Feature: Support workflow event dispatch via API Feature: Support workflow event dispatch via API Oct 2, 2024
lunny
lunny reviewed Oct 3, 2024
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@bencurio
Updated permissions
0357003 
Signed-off-by: Bence Santha <git@santha.eu>
lunny
lunny reviewed Oct 11, 2024
View reviewed changes
services/actions/workflow.go Outdated
return
}
workflows, err := jobparser.Parse(content)
if err != nil || len(workflows) == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will panic if err == nil.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it by adding a check for both the error and the empty workflows case. Now, it handles the scenario where len(workflows) == 0 after confirming that err == nil, preventing a potential panic.

@bencurio
Refactor workflow dispatch
1969e6b 
Signed-off-by: Bence Santha <git@santha.eu>
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bencurio @lunny @GiteaBot @techknowlogick