Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSRF token #32216

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Refactor CSRF token #32216

merged 3 commits into from
Oct 10, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 8, 2024 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 8, 2024
@wxiaoguang wxiaoguang mentioned this pull request Oct 8, 2024
Merged
@wxiaoguang wxiaoguang force-pushed the refactor-csrf branch 3 times, most recently from 23145b0 to e280fe7 Compare October 8, 2024 14:21
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2024
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 10, 2024 03:20
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2024
@wxiaoguang wxiaoguang merged commit dd83cfc into go-gitea:main Oct 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 10, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2024
@wxiaoguang wxiaoguang deleted the refactor-csrf branch October 10, 2024 03:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
581f19f 
* giteaofficial/main:
  Refactor CSRF token (go-gitea#32216)
  [skip ci] Updated translations via Crowdin
  Fix incorrect "Target branch does not exist" in PR title (go-gitea#32222)
  update git book link to v2 (go-gitea#32221)
  [skip ci] Updated translations via Crowdin
  Add null check for responseData.invalidTopics (go-gitea#32212)
  Fix bug when a token is given public only (go-gitea#32204)
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @wolfogre @GiteaBot