Calculate PublicOnly for org membership only once
#32234
Conversation
6543
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
delvh
changed the title
PublicOnly for org membership only once
pull-request-size
bot
added
size/L
GiteaBot
added
lgtm/need 1
models/organization/org.go
Outdated
| Where("`team_user`.org_id = ?", org.ID). | ||
| Join("INNER", "team_user", "`team_user`.team_id = team.id"). | ||
| And("`team_user`.uid = ?", userID). | ||
| Where(builder.In("team.id", userTeamIDbuilder(org.ID, userID))). |
There was a problem hiding this comment.
Looks like it's unnecessary select id from team where id in (select id where ....
There was a problem hiding this comment.
yes, but DBMS should optimize it out ... @lunny if you know how to have the function creating the builder query, to be used, while remove one select ... just tell me :)
|
As a habit, we almost check permission in service layer but not in models layer. What's the problem with the previous code? |
|
I can create a new func in the service witch checks permissions ... but we would have to alter the existing code a lot and i want to only touch it here for a explizite context ... : the refactoring that makes the #32211 diff smal |
the determination if a user can see public or private org membership is determined in different places ... I want to have that check in a single place ... |
This reverts commit 3af5ae7. because of error: "Unsupported condition type"
|
@lunny to #32234 (comment) i tryed: 3af5ae7 see https://github.com/go-gitea/gitea/actions/runs/11331009974/job/31510076461?pr=32234 it does not work, it errors with: |
|
(I tried to have a single source of truth for the query ... but if preferred i will just use duplicated code by have a builder version and classic xorm version) |
Refactoring of #32211
this move the PublicOnly() filter calcuation next to the DB querys and let it be decided by the Doer
Sponsored by Kithara Software GmbH