Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make owner/repo/pulls handlers use "PR reader" permission #32254

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Make owner/repo/pulls handlers use "PR reader" permission #32254

merged 2 commits into from
Oct 15, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 14, 2024 •
edited
Loading

Fix #32253 (partially)

Before, it uses "code reader"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2024
@wxiaoguang wxiaoguang mentioned this pull request Oct 14, 2024
Closed
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 14, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 14, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Oct 14, 2024
@wxiaoguang
Copy link
Contributor Author

image

image

@wxiaoguang wxiaoguang force-pushed the fix-repo-pr-read branch 4 times, most recently from 9e248b5 to 7790912 Compare October 14, 2024 13:43
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2024
@yp05327
Copy link
Contributor

yp05327 commented Oct 15, 2024 •
edited
Loading

user without code unit permission can see the file changes and details of commits, which means they can see the codes, is it a problem or not? As the original proposal is

The expecation would be, that with PR permission it would be possible to comment on the PR, but without access to the other tabs (code)

I think he means:
image

@wxiaoguang
Copy link
Contributor Author

user without code unit permission can see the file changes and details of commits, which means they can see the codes, is it a problem or not? As the original proposal is

The expecation would be, that with PR permission it would be possible to comment on the PR, but without access to the other tabs (code)

I think he means: image

That's arguable and not in this PR's scope. You could edit this PR directly or propose a new one to replace. At the moment I have no willing to do more change

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 15, 2024 06:18
@wxiaoguang wxiaoguang merged commit 5242e52 into go-gitea:main Oct 15, 2024
26 checks passed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.22. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 32254
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 15, 2024
@yp05327 yp05327 mentioned this pull request Oct 15, 2024
Open
@wxiaoguang wxiaoguang deleted the fix-repo-pr-read branch October 15, 2024 06:53
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Oct 15, 2024
@wxiaoguang
Make owner/repo/pulls handlers use "PR reader" permission (go-gitea…
3019b00 
…#32254)

Fix go-gitea#32253 (partially)
@wxiaoguang wxiaoguang mentioned this pull request Oct 15, 2024
Open
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Pull Request access requires code access
4 participants
@wxiaoguang @yp05327 @GiteaBot @lunny