Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low-hanging fruit in English (source) translation #3518

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

bugreport0
Copy link
Contributor

This PR fixes the low-hanging fruit from issue #3512 which is non-subjective:

  • ellipses are used instead of repeated periods
  • spacing before ellipses is now consistent (no space)
  • one missing 'a' is added
  • 'an' is used before words starting with a vowel
  • the term 'username' is consistently used

@codecov-io
Copy link

codecov-io commented Feb 15, 2018

Codecov Report

Merging #3518 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
+ Coverage   35.68%   35.69%   +<.01%     
==========================================
  Files         281      281              
  Lines       40701    40701              
==========================================
+ Hits        14524    14527       +3     
+ Misses      24029    24028       -1     
+ Partials     2148     2146       -2
Impacted Files Coverage Δ
models/repo_indexer.go 48.3% <0%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b48a45...aff1675. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2018
@lafriks lafriks added this to the 1.5.0 milestone Feb 15, 2018
@lunny
Copy link
Member

lunny commented Feb 16, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2018
@bugreport0
Copy link
Contributor Author

bugreport0 commented Feb 16, 2018

Hurray for the LGTM, but maybe we should aim for structural improvements here. Would it be possible to / can someone write a unit test that greps all translations to make sure that:

  • no occurrences of three repeated periods '...' are allowed
  • no occurrences of an ellipsis with a space in front ' …' are allowed

This would document and codify some initial translation rules. We could possibly expand on that in the future.

@lunny
Copy link
Member

lunny commented Feb 16, 2018

@bugreport0 That unit test could be another PR. Let's merge this one at first.

@lunny lunny merged commit 9303fc2 into go-gitea:master Feb 16, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants