Add topic support #3711

lunny · 2018-03-23T15:18:39Z

This PR will view a repository's topics and let repositorys owners to manage topics.

Will fix #219

codecov-io · 2018-03-23T16:12:58Z

Codecov Report

❗ No coverage uploaded for pull request base (master@1946ce2). Click here to learn what that means.
The diff coverage is 42.75%.

@@            Coverage Diff            @@
##             master    #3711   +/-   ##
=========================================
  Coverage          ?   23.02%           
=========================================
  Files             ?      126           
  Lines             ?    24894           
  Branches          ?        0           
=========================================
  Hits              ?     5731           
  Misses            ?    18287           
  Partials          ?      876

Impacted Files	Coverage Δ
models/repo.go	`17.32% <ø> (ø)`
routers/repo/view.go	`0% <0%> (ø)`
routers/repo/topic.go	`0% <0%> (ø)`
models/topic.go	`54.12% <54.12%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1946ce2...4a1f5a3. Read the comment docs.

lunny · 2018-03-25T13:01:47Z

I think it's ready for review.

jonasfranz · 2018-03-29T07:11:55Z

@lunny conflicted

jonasfranz · 2018-03-29T07:14:18Z

IMHO the color of the badges do not really fit to the design of gitea. We should use a sort of blue color (like links) or a green color like the logo.

lunny · 2018-03-29T08:39:13Z

conflict resolved. I will try to find another tag color.

lunny · 2018-03-29T09:14:03Z

@JonasFranzDEV changed to green basic style.

jonasfranz · 2018-03-29T09:34:43Z

When I create a new repo and add some topics it looks like:

When I reload it looks like:

lunny · 2018-03-30T15:24:05Z

@JonasFranzDEV fixed.

appleboy · 2018-04-01T06:52:01Z

public/js/index.js

+            throttle: 500,
+            cache: false,
+            onResponse: function(res) {
+                console.log(res)


remove debug message?

appleboy · 2018-04-01T06:52:30Z

public/js/index.js

+        },
+    });
+
+    $("span.sizer").change(function(){


remove debug message.

lafriks · 2018-04-09T19:31:50Z

models/repo.go

@@ -199,6 +199,7 @@ type Repository struct {
 	Size          int64              `xorm:"NOT NULL DEFAULT 0"`
 	IndexerStatus *RepoIndexerStatus `xorm:"-"`
 	IsFsckEnabled bool               `xorm:"NOT NULL DEFAULT true"`
+	Topics        []string           `xorm:"TEXT JSON"`


Why is this saved to database?

For better performance when we list all topics for every repository on repositories list UI.

lafriks

Don't like duplicated staff in database as it usually brings it to sometimes not being updated but ok

marbetschar · 2018-04-12T14:12:49Z

@lafriks any chance of a new stable version any time soon which contains the topics? can't get it soon enough 😍 🎉 🤣

lafriks · 2018-04-12T19:45:29Z

@marbetschar 1.5.0 is planned to be release at the end of May but most probably that will be rc1 + 2-3 weeks to get to 1.5.0 so it's June :)

marbetschar · 2018-04-12T20:12:37Z

😱😱😱😱

🤣🤣

* SECURITY * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353) * Do not allow to reuse TOTP passcode (go-gitea#3878) * FEATURE * Add cli commands to regen hooks & keys (go-gitea#3979) * Add support for FIDO U2F (go-gitea#3971) * Added user language setting (go-gitea#3875) * LDAP Public SSH Keys synchronization (go-gitea#1844) * Add topic support (go-gitea#3711) * Multiple assignees (go-gitea#3705) * Add protected branch whitelists for merging (go-gitea#3689) * Global code search support (go-gitea#3664) * Add label descriptions (go-gitea#3662) * Add issue search via API (go-gitea#3612) * Add repository setting to enable/disable health checks (go-gitea#3607) * Emoji Autocomplete (go-gitea#3433) * Implements generator cli for secrets (go-gitea#3531) * ENHANCEMENT * Add more webhooks support and refactor webhook templates directory (go-gitea#3929) * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910) * Add option to use paged LDAP search when synchronizing users (go-gitea#3895) * Symlink icons (go-gitea#1416) * Improve release page UI (go-gitea#3693) * Add admin dashboard option to run health checks (go-gitea#3606) * Add branch link in branch list (go-gitea#3576) * Reduce sql query times in retrieveFeeds (go-gitea#3547) * Option to enable or disable swagger endpoints (go-gitea#3502) * Add missing licenses (go-gitea#3497) * Reduce repo indexer disk usage (go-gitea#3452) * Enable caching on assets and avatars (go-gitea#3376) * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969) * Add Environment Variables to Docker template (go-gitea#4012) * LFS: make HTTP auth period configurable (go-gitea#4035) * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184) * Refactor User Settings sections (go-gitea#3900) * Allow square brackets in external issue patterns (go-gitea#3408) * Add Attachment API (go-gitea#3478) * Add EnableTimetracking option to app settings (go-gitea#3719) * Add config option to enable or disable log executed SQL (go-gitea#3726) * Shows total tracked time in issue and milestone list (go-gitea#3341) * TRANSLATION * Improve English grammar and consistency (go-gitea#3614) * DEPLOYMENT * Allow Gitea to run as different USER in Docker (go-gitea#3961) * Provide compressed release binaries (go-gitea#3991) * Sign release binaries (go-gitea#4188)

Cyber1000 · 2018-07-20T17:41:00Z

Sorry to ask here, but I don't know where else:
Can you search after topics, or is it at least planned?
For now it seems I only can put topics on a repo and see it in the repo list, but I can't click on time like on github and get all repos relatet to this topic ...

Thanks!

William-LP · 2018-07-23T13:04:42Z

Hey, just tried under the last version 1.5.0-rc2 and it doesn't work :

Also the topics aren't clickable so this isn't possible to sort out the repo based on the topic

lafriks · 2018-07-23T14:07:50Z

Yes, searching and clicking on topics is currently not possible

lunny · 2018-07-23T17:05:44Z

This PR is a basic PR for topics. More PRs about topics are welcome!

appleboy · 2018-07-24T01:31:50Z

@Cyber1000 @William-LP See the PR #4505

gabrielsimoes · 2019-01-24T22:40:07Z

templates/repo/home.tmpl

@@ -5,7 +5,7 @@
 		{{template "base/alert" .}}
 		<div class="ui repo-description">
 			<div id="repo-desc">
-				{{if .Repository.DescriptionHTML}}<span class="description has-emoji">{{.Repository.DescriptionHTML}}</span>{{else if .IsRepositoryAdmin}}<span class="no-description text-italic">{{.i18n.Tr "repo.no_desc"}}</span>{{end}}
+				{{if .Repository.DescriptionHTML}}<span class="description has-emoji">{{.Repository.DescriptionHTML}}</span>{{else}}<span class="no-description text-italic">{{.i18n.Tr "repo.no_desc"}}</span>{{end}}


@lunny You accidentally removed #2167 here.

I addressed this on #5836

Why we need if .IsRepositoryAdmin?

The idea was to not display the "No Description" message to non-admins. That is, only the repo admin should see it.

@gabrielsimoes I think it's unnecessary to hide non-admins the message.

…2167 (#5836) Revert #3711 overwrite of only show "No Description" to repo admins #2167 and add tests to prevent accidental overwrite again.

…admins go-gitea#2167 (go-gitea#5836) Revert go-gitea#3711 overwrite of only show "No Description" to repo admins go-gitea#2167 and add tests to prevent accidental overwrite again.

lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review type/changelog Adds the changelog for a new Gitea version labels Mar 23, 2018

lunny added this to the 1.5.0 milestone Mar 23, 2018

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2018

lunny removed the pr/wip This PR is not ready for review label Mar 25, 2018

lunny force-pushed the lunny/topic branch from 9000eae to 49570bd Compare March 27, 2018 13:54

lunny force-pushed the lunny/topic branch from 49570bd to ae7c9a3 Compare March 29, 2018 08:38

appleboy suggested changes Apr 1, 2018

View reviewed changes

lunny force-pushed the lunny/topic branch from ce2a93c to 9eaa912 Compare April 1, 2018 10:02

lunny added 11 commits April 9, 2018 23:21

add topic models and unit tests

d07c1d5

fix comments

c10a04b

fix comment

1539511

add the UI to show or add topics for a repo

a405d40

show topics on repositories list

b634af1

fix test

cc5dc73

don't show manage topics link when no permission

4605ee5

use green basic as topic label

7373966

fix topic label color

0af3841

remove trace content

0b8190f

remove debug function

be00702

lunny force-pushed the lunny/topic branch from 9eaa912 to be00702 Compare April 9, 2018 15:21

appleboy approved these changes Apr 9, 2018

View reviewed changes

bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2018

lafriks requested changes Apr 9, 2018

View reviewed changes

lafriks approved these changes Apr 10, 2018

View reviewed changes

bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2018

lunny added 2 commits April 10, 2018 11:53

Merge branch 'master' into lunny/topic

d62b876

Merge branch 'master' into lunny/topic

4a1f5a3

lunny merged commit bec69f7 into go-gitea:master Apr 11, 2018

lunny deleted the lunny/topic branch April 11, 2018 02:51

appleboy mentioned this pull request Jul 24, 2018

Can't search repository by topic name #4504

Closed

7 tasks

techknowlogick mentioned this pull request Oct 25, 2018

Labels/Tags for repositories #5171

Closed

gabrielsimoes reviewed Jan 24, 2019

View reviewed changes

go-gitea locked and limited conversation to collaborators Nov 24, 2020

delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add topic support #3711

Add topic support #3711

lunny commented Mar 23, 2018 •

edited

Loading

codecov-io commented Mar 23, 2018 •

edited

Loading

lunny commented Mar 25, 2018

jonasfranz commented Mar 29, 2018

jonasfranz commented Mar 29, 2018

lunny commented Mar 29, 2018

lunny commented Mar 29, 2018

jonasfranz commented Mar 29, 2018

lunny commented Mar 30, 2018

appleboy Apr 1, 2018

appleboy Apr 1, 2018

lunny Apr 9, 2018

lafriks Apr 9, 2018

lunny Apr 10, 2018

lafriks left a comment

marbetschar commented Apr 12, 2018

lafriks commented Apr 12, 2018

marbetschar commented Apr 12, 2018

Cyber1000 commented Jul 20, 2018

William-LP commented Jul 23, 2018 •

edited

Loading

lafriks commented Jul 23, 2018

lunny commented Jul 23, 2018

appleboy commented Jul 24, 2018

gabrielsimoes Jan 24, 2019

gabrielsimoes Jan 25, 2019

lunny Jan 25, 2019

gabrielsimoes Jan 27, 2019

lunny Jan 28, 2019

Add topic support #3711

Add topic support #3711

Conversation

lunny commented Mar 23, 2018 • edited Loading

codecov-io commented Mar 23, 2018 • edited Loading

Codecov Report

lunny commented Mar 25, 2018

jonasfranz commented Mar 29, 2018

jonasfranz commented Mar 29, 2018

lunny commented Mar 29, 2018

lunny commented Mar 29, 2018

jonasfranz commented Mar 29, 2018

lunny commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lafriks left a comment

Choose a reason for hiding this comment

marbetschar commented Apr 12, 2018

lafriks commented Apr 12, 2018

marbetschar commented Apr 12, 2018

Cyber1000 commented Jul 20, 2018

William-LP commented Jul 23, 2018 • edited Loading

lafriks commented Jul 23, 2018

lunny commented Jul 23, 2018

appleboy commented Jul 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunny commented Mar 23, 2018 •

edited

Loading

codecov-io commented Mar 23, 2018 •

edited

Loading

William-LP commented Jul 23, 2018 •

edited

Loading