Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request review/approval and comment on code #3748

Merged
merged 104 commits into from
Aug 6, 2018

Commits on May 6, 2018

  1. Configuration menu
    Copy the full SHA
    85e1ad5 View commit details
    Browse the repository at this point in the history
  2. Add Review

    Add IssueComment types
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    
    (cherry picked from commit 2b4daab)
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 6, 2018
    Configuration menu
    Copy the full SHA
    623a9f6 View commit details
    Browse the repository at this point in the history
  3. Replace ReviewComment with Content

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 6, 2018
    Configuration menu
    Copy the full SHA
    aeb0577 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Add load functions

    Add ReviewID to findComments
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 10, 2018
    Configuration menu
    Copy the full SHA
    2c18552 View commit details
    Browse the repository at this point in the history
  2. Add create review comment implementation

    Add migration for review
    Other small changes
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 10, 2018
    Configuration menu
    Copy the full SHA
    9544c46 View commit details
    Browse the repository at this point in the history
  3. Simplified create and find functions for review

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 10, 2018
    Configuration menu
    Copy the full SHA
    0f772d1 View commit details
    Browse the repository at this point in the history
  4. Moved "Pending" to first position

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 10, 2018
    Configuration menu
    Copy the full SHA
    4ad563d View commit details
    Browse the repository at this point in the history
  5. Add GetCurrentReview to simplify fetching current review

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 10, 2018
    Configuration menu
    Copy the full SHA
    17af2d1 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Preview for listing comments

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    75b7d9b View commit details
    Browse the repository at this point in the history
  2. Move new comment form to its own file

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    e252d3b View commit details
    Browse the repository at this point in the history
  3. Implement Review form

    Show Review comments on comment stream
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    3e5f3c3 View commit details
    Browse the repository at this point in the history
  4. Add support for single comments

    Showing buttons in context
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    61cc134 View commit details
    Browse the repository at this point in the history
  5. Add pending tag to pending review comments

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    36d6631 View commit details
    Browse the repository at this point in the history
  6. Add unit tests for Review

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    9c6bb4b View commit details
    Browse the repository at this point in the history
  7. Fetch all review ids at once

    Add unit tests
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    bc93592 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2018

  1. gofmt

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 12, 2018
    Configuration menu
    Copy the full SHA
    58fb672 View commit details
    Browse the repository at this point in the history
  2. Improved comment rendering in "Files" view by adding Comments to Diff…

    …Line
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 12, 2018
    Configuration menu
    Copy the full SHA
    066086c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2018

  1. Add support for invalidating comments

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    7986d6e View commit details
    Browse the repository at this point in the history
  2. Switched back to code.gitea.io/git

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    cbdd8c9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from JonasFranzDEV/feat/approval

    Reviews and Pull Request comments
    lafriks authored May 13, 2018
    Configuration menu
    Copy the full SHA
    2f46613 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into feat/approval-new

    # Conflicts:
    #	models/issue_comment.go
    #	models/migrations/migrations.go
    #	models/migrations/v64.go
    #	models/models.go
    #	public/css/index.css
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    6d00c1a View commit details
    Browse the repository at this point in the history
  5. Moved review migration from v64 to v65

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    7723e15 View commit details
    Browse the repository at this point in the history
  6. Rebuild css

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    90d9dda View commit details
    Browse the repository at this point in the history
  7. gofmt

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    5f55ede View commit details
    Browse the repository at this point in the history
  8. Improve translations

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 13, 2018
    Configuration menu
    Copy the full SHA
    d2b4347 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Fix unit tests by updating fixtures and updating outdated test

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ed695c1 View commit details
    Browse the repository at this point in the history
  2. Comments will be shown at the right place now

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 14, 2018
    Configuration menu
    Copy the full SHA
    de7081c View commit details
    Browse the repository at this point in the history
  3. Add support for deleting CodeComments

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7c4bf56 View commit details
    Browse the repository at this point in the history
  4. Fix problems caused by files in subdirectories

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 14, 2018
    Configuration menu
    Copy the full SHA
    6ae32b2 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. Add support for showing code comments of reviews in conversation

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 15, 2018
    Configuration menu
    Copy the full SHA
    4ea74e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c1edf9 View commit details
    Browse the repository at this point in the history
  3. Add support for "Show/Hide outdated"

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 15, 2018
    Configuration menu
    Copy the full SHA
    8bb5113 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. Update code.gitea.io/git

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 17, 2018
    Configuration menu
    Copy the full SHA
    5c2171e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f64dad View commit details
    Browse the repository at this point in the history
  3. Add support for new webhooks

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 17, 2018
    Configuration menu
    Copy the full SHA
    6e55557 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Update comparison

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 19, 2018
    Configuration menu
    Copy the full SHA
    05df5a7 View commit details
    Browse the repository at this point in the history
  2. Resolve conflicts

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 19, 2018
    Configuration menu
    Copy the full SHA
    e5bde14 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into feat/approval-new

    # Conflicts:
    #	models/error.go
    #	models/migrations/migrations.go
    #	models/models.go
    #	public/js/index.js
    jonasfranz committed May 19, 2018
    Configuration menu
    Copy the full SHA
    a8dc699 View commit details
    Browse the repository at this point in the history
  4. Minor UI improvements

    lafriks committed May 19, 2018
    Configuration menu
    Copy the full SHA
    8ea8209 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2018

  1. Configuration menu
    Copy the full SHA
    a550052 View commit details
    Browse the repository at this point in the history
  2. update code.gitea.io/git

    jonasfranz committed May 21, 2018
    Configuration menu
    Copy the full SHA
    0f88cb8 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. Merge branch 'master' into feat/approval

    # Conflicts:
    #	vendor/vendor.json
    jonasfranz committed May 22, 2018
    Configuration menu
    Copy the full SHA
    e60b3f6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Configuration menu
    Copy the full SHA
    a05d052 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27c488e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Fix ui bug reported by @lunny causing wrong position of add button

    Add functionality to "Cancel" button
    Add scale effects to add button
    Hide "Cancel" button for existing comments
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 24, 2018
    Configuration menu
    Copy the full SHA
    2b6001b View commit details
    Browse the repository at this point in the history
  2. Prepare solving conflicts

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 24, 2018
    Configuration menu
    Copy the full SHA
    d25df5b View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into feat/approval-new

    # Conflicts:
    #	models/migrations/migrations.go
    jonasfranz committed May 24, 2018
    Configuration menu
    Copy the full SHA
    7592f5b View commit details
    Browse the repository at this point in the history
  4. Show add button only if no comments already exist for the line

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 24, 2018
    Configuration menu
    Copy the full SHA
    4cb3a60 View commit details
    Browse the repository at this point in the history
  5. Add missing vendor files

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 24, 2018
    Configuration menu
    Copy the full SHA
    f64f8e0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f07b4e1 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Check if reviewer is nil

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 25, 2018
    Configuration menu
    Copy the full SHA
    4ad72de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2f60f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    229129d View commit details
    Browse the repository at this point in the history
  4. Show forms only to users who are logged in

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 25, 2018
    Configuration menu
    Copy the full SHA
    c083682 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. Revert "Show forms only to users who are logged in"

    This reverts commit c083682
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 29, 2018
    Configuration menu
    Copy the full SHA
    c7dffe6 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2018

  1. Save patch in comment

    Render patch for code comments
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    4d0abce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c79e5a1 View commit details
    Browse the repository at this point in the history
  3. Add link to comment in code

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    39fcc99 View commit details
    Browse the repository at this point in the history
  4. Add reply form to comment list

    Show forms only to signed in users
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    9a0c394 View commit details
    Browse the repository at this point in the history
  5. Add 'Reply' as translatable

    Add CODE_COMMENT_LINES setting
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    c8c1e70 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    853ed7d View commit details
    Browse the repository at this point in the history
  7. gofmt

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    b6d8aea View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e3f87a9 View commit details
    Browse the repository at this point in the history
  9. Fix problems introduced by checking for singed in user

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed May 31, 2018
    Configuration menu
    Copy the full SHA
    3f48c7c View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. Configuration menu
    Copy the full SHA
    b4e43d6 View commit details
    Browse the repository at this point in the history
  2. Add v70

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    45dabaf View commit details
    Browse the repository at this point in the history
  3. Update generated stylesheet

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    b553556 View commit details
    Browse the repository at this point in the history
  4. Fix preview

    Beginn with new review comment patch system
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    73b325c View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2018

  1. Add new algo to generate diff for line range

    Remove old algo used for cutting big diffs (it was very buggy)
    jonasfranz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    3cd5ee4 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of https://github.com/go-gitea/gitea into feat/…

    …approval-new
    
    Add additional benchmarks and gofmt
    jonasfranz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    7f0eb69 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a84f04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fbaeb02 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5dd39d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aee593b View commit details
    Browse the repository at this point in the history
  7. Send notifications / actions to users until review gets published

    Fix diff generation bug
    Fix wrong hashtag
    jonasfranz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    8f77329 View commit details
    Browse the repository at this point in the history
  8. Fix vet errors

    jonasfranz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    d8ddade View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dbc7aee View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a0d9afd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b2092fe View commit details
    Browse the repository at this point in the history
  12. Add lint comment

    jonasfranz committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    3013c0c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2018

  1. Configuration menu
    Copy the full SHA
    858345d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e340181 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Add more error messages

    jonasfranz committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    3f39e23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6de1f38 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. Configuration menu
    Copy the full SHA
    65d4318 View commit details
    Browse the repository at this point in the history
  2. Regenerated css

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e7b2b61 View commit details
    Browse the repository at this point in the history
  3. fmt

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    8a6e6dc View commit details
    Browse the repository at this point in the history
  4. Regenerated CSS with latest less version

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    5554ad2 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2018

  1. Configuration menu
    Copy the full SHA
    b29e722 View commit details
    Browse the repository at this point in the history
  2. Fix test by updating comment type to new ID

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    cb29fdb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. Introducing CodeComments as type for map[string]map[int64][]*Comment

    Other minor code improvements
    
    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    021f028 View commit details
    Browse the repository at this point in the history
  2. Fix data-tab issues

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    5539c96 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7eec104 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary change

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    ce07867 View commit details
    Browse the repository at this point in the history
  5. refactored checkForInvalidation

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    dc4a27d View commit details
    Browse the repository at this point in the history
  6. Append comments instead of setting

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    4c76cf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Use HeadRepo instead of BaseRepo

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    77caec7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1a3e6f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. Configuration menu
    Copy the full SHA
    a116913 View commit details
    Browse the repository at this point in the history
  2. Update migration

    Signed-off-by: Jonas Franz <info@jonasfranz.de>
    jonasfranz committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    64269ef View commit details
    Browse the repository at this point in the history
  3. Regenerated CSS

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    7888318 View commit details
    Browse the repository at this point in the history
  4. Add copyright

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    638ea14 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2018

  1. Configuration menu
    Copy the full SHA
    c503a70 View commit details
    Browse the repository at this point in the history
  2. Update index.css

    Signed-off-by: Jonas Franz <info@jonasfranz.software>
    jonasfranz committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    5f8c9a2 View commit details
    Browse the repository at this point in the history