Fix wiki redirects #3919
Merged
Fix wiki redirects #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3919 +/- ##
=======================================
Coverage 19.96% 19.96%
=======================================
Files 153 153
Lines 30478 30478
=======================================
Hits 6086 6086
Misses 23479 23479
Partials 913 913
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
yasuokav
reviewed
May 24, 2018
routers/repo/wiki.go
Outdated
| @@ -350,7 +350,7 @@ func NewWikiPost(ctx *context.Context, form auth.NewWikiForm) { | |||
| return | |||
| } | |||
|
|
|||
| ctx.Redirect(ctx.Repo.RepoLink + "/wiki/" + models.WikiNameToFilename(wikiName)) | |||
| ctx.Redirect(ctx.Repo.RepoLink + "/wiki/" + wikiName) | |||
There was a problem hiding this comment.
I think WikiNameToSubURL should be here.
There was a problem hiding this comment.
Thanks! I missed this function completely. :-) I have pushed an updated version of the PR.
When creating or editing a wiki page, the redirect to the wiki page does not work because the file name is used instead of the page name.
lafriks
approved these changes
May 28, 2018
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
May 28, 2018
bkcsoft
added
lgtm/done
techknowlogick
pushed a commit
that referenced
this pull request
May 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating or editing a wiki page, the redirect to the wiki page does not work because the file name is used instead of the page name.
This happens on our instance since upgrading to Gitea 1.4. If the PR is okay, I will also prepare a backport for 1.4.