Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust z-index for floating labels #3939

Merged
merged 2 commits into from
May 11, 2018
Merged

Adjust z-index for floating labels #3939

merged 2 commits into from
May 11, 2018

Conversation

daviian
Copy link
Member

@daviian daviian commented May 10, 2018

Targets #3730

PR reduces overall z-index of floating labels. However respects corner cases when used in dropdowns.

@codecov-io
Copy link

codecov-io commented May 10, 2018 •
edited
Loading

Codecov Report

Merging #3939 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3939   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files         146      146           
  Lines       29316    29316           
=======================================
  Hits         5945     5945           
  Misses      22470    22470           
  Partials      901      901

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253a2d6...ba66bea. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2018
@lunny lunny added this to the 1.5.0 milestone May 10, 2018
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels May 10, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2018
@lafriks lafriks mentioned this pull request May 10, 2018
Closed
7 tasks
@appleboy appleboy merged commit 91b3615 into go-gitea:master May 11, 2018
@appleboy
Copy link
Member

@daviian Plase send PR to v1.4 release branch.

@daviian daviian deleted the fix-badge-overlap branch May 11, 2018 09:53
daviian added a commit to daviian/gitea that referenced this pull request May 11, 2018
@daviian
Adjust z-index for floating labels (go-gitea#3939)
de377f8
lafriks pushed a commit that referenced this pull request May 11, 2018
@daviian @lafriks
Adjust z-index for floating labels (#3939) (#3950)
50adbb7
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@daviian @codecov-io @appleboy @lafriks @lunny @bkcsoft