Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom regular expression for external issue tracking. #4265

Closed

Conversation

AlexanderBeyn
Copy link
Contributor

This PR adds regex as a third style of external issue tracking. The regular expression must have at least one captured group, which will be used as the index for the link. The entire match replaced by the link when rendered.

Fixes #3468

Signed-off-by: Alexander Beyn <malex@fatelectrons.org>
@codecov-io
Copy link

codecov-io commented Jun 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9ce4d89). Click here to learn what that means.
The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4265   +/-   ##
=========================================
  Coverage          ?   41.54%           
=========================================
  Files             ?      449           
  Lines             ?    61329           
  Branches          ?        0           
=========================================
  Hits              ?    25480           
  Misses            ?    32496           
  Partials          ?     3353
Impacted Files Coverage Δ
models/repo_unit.go 64.91% <ø> (ø)
modules/auth/repo_form.go 41.73% <ø> (ø)
routers/repo/setting.go 9.28% <0%> (ø)
models/repo.go 48.39% <100%> (ø)
modules/markup/html.go 80.76% <90.32%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce4d89...49b3ebc. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 18, 2018
@lunny lunny added this to the 1.x.x milestone Jun 18, 2018
@stale
Copy link

stale bot commented Jan 5, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 5, 2019
@stale
Copy link

stale bot commented Mar 6, 2019

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this Mar 6, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Mar 16, 2019
@lunny lunny reopened this Mar 16, 2019
@techknowlogick
Copy link
Member

I've resolved the merge conflicts, however due to some recent changes the tests are failing

@techknowlogick techknowlogick modified the milestones: 1.x.x, 1.9.0 Apr 24, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 25, 2019
@techknowlogick techknowlogick modified the milestones: 1.10.0, 1.11.0 Sep 3, 2019
@lunny
Copy link
Member

lunny commented Nov 16, 2019

Please resolve the conflicts

@lunny lunny modified the milestones: 1.11.0, 1.12.0 Dec 17, 2019
@lafriks lafriks modified the milestones: 1.12.0, 1.13.0 May 16, 2020
@lunny lunny modified the milestones: 1.13.0, 1.14.0 Sep 5, 2020
@lunny lunny modified the milestones: 1.14.0, 1.x.x Jan 27, 2021
@strk
Copy link
Member

strk commented Nov 12, 2021

@AlexanderBeyn thanks a lot for this, are you planning to resolve the conflicts ?

@strk
Copy link
Member

strk commented Nov 12, 2021

@lunny I've resolved the conflicts in #17624 (using a rebase operation - don't know if I'm authorized of committing to this branch)

@wxiaoguang
Copy link
Contributor

Thank you for your contribution! There is a new PR based on your work.

@wxiaoguang wxiaoguang closed this Jun 9, 2022
@delvh delvh removed this from the 1.x.x milestone Jun 9, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom regex patterns for linking external issues
10 participants