Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.5.0-RC1 #4324

Merged
merged 12 commits into from
Jul 3, 2018
Merged

Add changelog for 1.5.0-RC1 #4324

merged 12 commits into from
Jul 3, 2018

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jun 27, 2018

As title

Blocked by #4323

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR pr/wip This PR is not ready for review labels Jun 27, 2018
@techknowlogick techknowlogick added this to the 1.5.0 milestone Jun 27, 2018
@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #4324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4324   +/-   ##
======================================
  Coverage    20.1%   20.1%           
======================================
  Files         153     153           
  Lines       30715   30715           
======================================
  Hits         6174    6174           
  Misses      23598   23598           
  Partials      943     943

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf9abd...c0ce923. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2018
@techknowlogick techknowlogick removed the pr/wip This PR is not ready for review label Jun 27, 2018
@techknowlogick techknowlogick changed the title [WIP] Add changelog for 1.5.0-RC1 Add changelog for 1.5.0-RC1 Jun 27, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 27, 2018
@lunny lunny removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jun 27, 2018
@lunny
Copy link
Member

lunny commented Jun 27, 2018

conflict

CHANGELOG.md Outdated
* Fix webhook type conflation. (#4285)
* Change parsing of postgresql settings (#4275)
* Fix milestone appliance and permission checks (#4271)
* Fix topics addition (Another solution) (#4031) (#4258)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed (was introduced by new feature)

CHANGELOG.md Outdated
* Fix swagger security part (#4236)
* Delete reactions added to issues and comments when deleting repository (#4232)
* Fix delete comment bug (#4216)
* Fix not respecting landing page setting (#4209)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a regression from another PR.

CHANGELOG.md Outdated
* Fix typo in OAUTH page (#4151)
* Only show "You cannot fork a repository you own" when needed. (#4130)
* Removed unnecessary line referencing LFS struct (#4113)
* Remove dupelicate link (#4100)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo

CHANGELOG.md Outdated
* Removed unnecessary line referencing LFS struct (#4113)
* Remove dupelicate link (#4100)
* Update gitgraph.js to fix "Cannot read property color of undefined" (#4095)
* Fix #4090 by escaping filename page/img link (without path) for short link (#4091)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already part of 1.4.3 (wiki url encoding)
Also security?

CHANGELOG.md Outdated
* Fix topics addition (Another solution) (#4031) (#4258)
* Fix #4060 by showing second line of commit (#4251)
* Fix swagger security part (#4236)
* Delete reactions added to issues and comments when deleting repository (#4232)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already part of 1.4.3

CHANGELOG.md Outdated
* Add "error" as reserved username (#3882)
* Fix path cleanup in multiple places (#3871)
* Fix to use only needed columns from tables to get repository git paths (#3870)
* Fix only updated_unix when adding a comment (#3855)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.1

CHANGELOG.md Outdated
* don't reset team/repo count when updating team via API (#3831)
* Don't force due date to current time (#3830)
* Fixed 0 closed issues not show 50% closed on activty page (#3802)
* Fix typo in deleteUser (#3781)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.1

CHANGELOG.md Outdated
* Show Clipboard button if disable HTTP of git protocol (#3773)
* Enhance healthcheck for database connectivity (#3754)
* Add tag check to release draft creation (#3729)
* Use the active branch for the code tab (#3720)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.1

CHANGELOG.md Outdated
* Enhance healthcheck for database connectivity (#3754)
* Add tag check to release draft creation (#3729)
* Use the active branch for the code tab (#3720)
* Set default branchname on first push (#3715)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.1

CHANGELOG.md Outdated
* Fixed 0 closed issues not show 50% closed on activty page (#3802)
* Fix typo in deleteUser (#3781)
* Remove unnecessary Safe tags (#3778)
* Show Clipboard button if disable HTTP of git protocol (#3773)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.1

@lafriks
Copy link
Member

lafriks commented Jun 27, 2018

I think changelog should be only generated from label changloge and milstone 1.5.0 to keep it clean:
https://github.com/go-gitea/gitea/issues?q=label%3Achangelog+is%3Aclosed+milestone%3A1.5.0

If anything else from this needs to be included label shoud be added to that PR

Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment to have changelog cleaner and more useful

@techknowlogick
Copy link
Member Author

@lunny conflict resolved
@daviian / @lafriks thanks for feedback. I've changed the list to only include the items with changelog label

@lafriks
Copy link
Member

lafriks commented Jun 27, 2018

It is probably worth to review if there is anything else that is worth to mention in there and than label should be added to that issue

@axifive
Copy link
Member

axifive commented Jun 27, 2018

@lafriks, may be sorting enhancement #3969

@techknowlogick
Copy link
Member Author

@axifive added.

@lafriks / @daviian please review changes

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2018
@lafriks
Copy link
Member

lafriks commented Jul 1, 2018

@daviian need your approval

@sapk
Copy link
Member

sapk commented Jul 3, 2018

We can also add #4188 to indicate that binary can be checked with the public key. We could also indicate the public key fingerprint.

@daviian
Copy link
Member

daviian commented Jul 3, 2018

There are many more security fixes that didn't find it's way to a minor version of 1.4
These should be included as well.

Also I think there are further noticable PR's.
See https://github.com/go-gitea/gitea/pulls?utf8=%E2%9C%93&q=is%3Aclosed+milestone%3A1.5.0+is%3Apr+-label%3Akind%2Fdocs++-label%3Abackport%2Fv1.4+-label%3Akind%2Fbug+-label%3Akind%2Ftranslation+-label%3Achangelog
Of course not all of them, but some.

@lafriks
Copy link
Member

lafriks commented Jul 3, 2018

@daviian I added changelog label to 11 more PR's from that list, just need to add them also to this PR

@lafriks
Copy link
Member

lafriks commented Jul 3, 2018

@daviian @sapk done

@lafriks lafriks merged commit 9c6801c into go-gitea:master Jul 3, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-6 branch July 3, 2018 20:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants