Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column droping for MySQL that need a new session for the new transaction #4459

Closed
wants to merge 1 commit into from
Closed

Fix column droping for MySQL that need a new session for the new transaction #4459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions models/migrations/v64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ func addMultipleAssignees(x *xorm.Engine) error {
if err := sess.Commit(); err != nil {
return err
}

sess.Close()
sess = x.NewSession()
defer sess.Close()

if err := sess.Begin(); err != nil {
return err
}
Expand Down
5 changes: 5 additions & 0 deletions models/migrations/v69.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ func moveTeamUnitsToTeamUnitTable(x *xorm.Engine) error {
if err := sess.Commit(); err != nil {
return err
}

sess.Close()
sess = x.NewSession()
defer sess.Close()

if err := sess.Begin(); err != nil {
return err
}
Expand Down