Star glyph not rendering correctly

[Wqrld]

fix #4515

[Wqrld]

failing with sh: write error: Resource temporarily unavailable, any idea why?

[Wqrld]

Fixed CI

[Wqrld]

CI failed on mysql but that seems to be just a cloudfront outage.

EDIT: packagelock seems to have changed, is that a problem?

[techknowlogick]

package lock updates aren't needed to change the CSS

[Wqrld]

yes, this hapenned when npm installing less

[techknowlogick]

with git you can:

git add public/css/index.css
git add  public/less/_repository.less
git commit

that will only add specific files to your commit.

[techknowlogick]

CI restarted

[codecov-io]

Codecov Report

Merging #4532 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4532   +/-   ##
======================================
  Coverage    20.2%   20.2%           
======================================
  Files         156     156           
  Lines       31140   31140           
======================================
  Hits         6292    6292           
  Misses      23890   23890           
  Partials      958     958

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74426d...f3576fb. Read the comment docs.

[lafriks]

I don't think that is correct way to fix this. I'm on mobile can't check right now but fa class should set correct font family already

[exside]

@lafriks agreed, but there is some strange interference between the Semantic UI iconfont and fontawesome...guess that's causing all the trouble.

[atom0s]

Simply changing the icon type from fa-star-o to fa-star fixes this rather than a bunch of file edits.

[techknowlogick]

@atom0s sadly that change also isn't entirely effective, as it would break logic: <i class="icon fa-star{{if not $.IsStaringRepo}}-o{{end}}"></i> is the existing logic, and changing it would mean that a user couldn't tell if they are have starred the repo yet.

[lafriks]

Does not changing to <i class="icon fa fa-star{{if not $.IsStaringRepo}}-o{{end}}"></i> help?

[techknowlogick]

@lafriks that specific change didn't work, however I found replacing icon with fa worked. Even though it did work I'm still unsure about it because icon is used everywhere else in the application.

[lafriks]

@techknowlogick @Wqrld it is caused by semantic ui update.
This is correct solution for unstarred use: <i class="icon star outline"></i> for starred: <i class="icon star"></i>

So template file should have:

<i class="icon star{{if not $.IsStaringRepo}} outline{{end}}"></i>

[techknowlogick]

That's great news! I should be waking up in a few hours and can submit a PR with that change, or if you get to it before me I can give it my LG-TM

[lafriks]

I have submitted fix, closing this