-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/serve: pprof cpu and memory profile dumps to disk #4560
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
96ec67f
cmd/serve: pprof memory profile dumps to disk (usefull for #4450)
xor-gate 4808ca3
cmd/serve: Allow pprof per-key
xor-gate 8893394
cmd/serve: Add setting for PPROF_DATA_PATH and break pprof code into …
xor-gate 3c19346
Process last review comments
xor-gate 0eaa416
Merge branch 'master' into issue-4450
xor-gate da76139
cmd/serv: Fix typo
xor-gate 0ce9b27
Merge branch 'issue-4450' of github.com:xor-gate/gitea into issue-4450
xor-gate 5159a19
Merge branch 'master' into issue-4450
lunny 0ab3e63
Merge branch 'master' into issue-4450
techknowlogick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright 2018 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package pprof | ||
|
||
import ( | ||
"fmt" | ||
"io/ioutil" | ||
"runtime" | ||
"runtime/pprof" | ||
|
||
"code.gitea.io/gitea/modules/log" | ||
) | ||
|
||
// DumpMemProfileForUsername dumps a memory profile at pprofDataPath as memprofile_<username>_<temporary id> | ||
func DumpMemProfileForUsername(pprofDataPath, username string) { | ||
f, err := ioutil.TempFile(pprofDataPath, fmt.Sprintf("memprofile_%s_", username)) | ||
if err != nil { | ||
log.GitLogger.Fatal(4, "Could not create memory profile: %v", err) | ||
} | ||
defer f.Close() | ||
runtime.GC() // get up-to-date statistics | ||
if err := pprof.WriteHeapProfile(f); err != nil { | ||
log.GitLogger.Fatal(4, "Could not write memory profile: %v", err) | ||
} | ||
} | ||
|
||
// DumpCPUProfileForUsername dumps a CPU profile at pprofDataPath as cpuprofile_<username>_<temporary id> | ||
// it returns the stop function which stops, writes and closes the CPU profile file | ||
func DumpCPUProfileForUsername(pprofDataPath, username string) func() { | ||
f, err := ioutil.TempFile(pprofDataPath, fmt.Sprintf("cpuprofile_%s_", username)) | ||
if err != nil { | ||
log.GitLogger.Fatal(4, "Could not create cpu profile: %v", err) | ||
} | ||
|
||
pprof.StartCPUProfile(f) | ||
return func() { | ||
pprof.StopCPUProfile() | ||
f.Close() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this line you also need:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, will fix that.