fix url in discord webhook #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opening issues generates a webhook to discord that contains a url to the gitea api. the message title in discord is therefore referencing to the api instead of the issue itself.
lafriks
approved these changes
Sep 18, 2018
bkcsoft
added
the
lgtm/need 1
lunny
approved these changes
Sep 18, 2018
bkcsoft
added
lgtm/done
|
Please send backport to release/v1.5 branch |
|
Oh I just noticed that this PR is for release/v1.5 branch. You should send PR to master branch first next time. Please backport to master than. |
|
was late yesterday. sorry for that |
|
Is this a fix for #4656 ? |
|
@adelowo yes |
|
thx @adelowo for pointing out that issue number. that's exactly the issue that is addressed by this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening issues generates a webhook to discord that contains
a url to the gitea api. the message title in discord is therefore
referencing to the api instead of the issue itself.