Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issues cannot be created with labels #622

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Fix: Issues cannot be created with labels #622

merged 1 commit into from
Jan 10, 2017

Conversation

kaz
Copy link
Contributor

@kaz kaz commented Jan 9, 2017

Now POST /issues/new receives form.LabelIDs with a trailing comma.

This causes an error here ↓
https://github.com/go-gitea/gitea/blob/master/routers/repo/issue.go#L392-L395
ValidateRepoMetas returns nil, 0, 0

Due to this, new issues cannot be created with labels, milestones, and assignees.
I modified client-side js to remove the trailing comma.

This bug seems to be caused by this change ↓
4c89a9c#diff-88e948dbecd728e2513ba9bafe876faaL465

Signed-off-by: Kazuki Sawada <kazuki@6715.jp>
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2017
@Bwko
Copy link
Member

Bwko commented Jan 10, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 10, 2017
@lunny lunny added the type/bug label Jan 10, 2017
@lunny lunny merged commit e5620f0 into go-gitea:master Jan 10, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants