Fix dump command

[kerie]

Fix #6310

The TableName() method defined on pointer receivers is not invoked by Xorm. Change method receivers to non-pointer receivers.

[codecov-io]

Codecov Report

Merging #6385 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6385      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.02%     
==========================================
  Files         365      365              
  Lines       51360    51360              
==========================================
- Hits        19957    19951       -6     
- Misses      28530    28537       +7     
+ Partials     2873     2872       -1

Impacted Files	Coverage Δ
models/oauth2_application.go	54.83% <100%> (ø)	⬆️
models/unit.go	0% <0%> (-14.29%)	⬇️
routers/repo/view.go	41.08% <0%> (-1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78cbbc...7763409. Read the comment docs.

[sapk]

Sorry for the too quick L-GTM.
Strangely, the xorm docs say If struct or pointer of struct has TableName() string method, the return value will be the struct’s table name.

What are the impact on the gitea database? Does the web command use the good tablename ? Or does this PR will also change it ? In this case it will need a migration. If not we should find why the dump command don't use it like the web command.

[lunny]

I think @sapk is right. This PR will not work. I will send another PR to fix that.

[lunny]

Won't work

[kerie]

Thank you for your quick response. The new PR is awesome, and I will close this one.

[lunny]

@kerie Anyway, thank you for your help!