Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6655 - Don't EscapePound .Link as it is already escaped #6656

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix #6655 - Don't EscapePound .Link as it is already escaped #6656

merged 1 commit into from
Apr 16, 2019

Conversation

zeripath
Copy link
Contributor

Fixes #6655

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix 6655 - there is no need to EscapePound .Link as it is already esc…
2812da6 
…aped

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.9.0 milestone Apr 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #6656 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6656      +/-   ##
==========================================
+ Coverage   40.54%   40.55%   +0.01%     
==========================================
  Files         406      406              
  Lines       54501    54501              
==========================================
+ Hits        22095    22101       +6     
+ Misses      29370    29363       -7     
- Partials     3036     3037       +1
Impacted Files Coverage Δ
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d01b98...2812da6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2019
@zeripath zeripath merged commit 450fc9a into go-gitea:master Apr 16, 2019
@zeripath zeripath deleted the fix-6655-url-escaping-in-create-pr branch April 17, 2019 18:43
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 17, 2019
@zeripath
Fix 6655 - there is no need to EscapePound .Link as it is already esc…
fb67a1a 
…aped (go-gitea#6656)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Apr 17, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Apr 17, 2019
@zeripath @techknowlogick
Fix 6655 - there is no need to EscapePound .Link as it is already esc…
0acaa6b 
…aped (#6656) (#6666)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente approved these changes

@richmahn richmahn richmahn approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Text replacing issues in post requests
6 participants
@zeripath @codecov-io @richmahn @kolaente @techknowlogick @GiteaBot