Fixed bugs on Wiki and resolved #667 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bwko
reviewed
Jan 15, 2017
| @@ -89,7 +89,7 @@ func discardLocalWikiChanges(localPath string) error { | |||
| } | |||
|
|
|||
| // updateWikiPage adds new page to repository wiki. | |||
| func (repo *Repository) updateWikiPage(doer *User, oldTitle, title, content, message string, isNew bool) (err error) { | |||
| func (repo *Repository) updateWikiPage(doer *User, oldWikiPath, wikiPath, content, message string, isNew bool) (err error) { | |||
There was a problem hiding this comment.
Delete wiki by path not the title. we have to give the real meaning of the variables.
There was a problem hiding this comment.
But now wikiPath contains the title of the page and not the /path/to/wiki/page
There was a problem hiding this comment.
No. wikiPath will not contain title. See AddWikiPage and EditWikiPage which will call the function.
There was a problem hiding this comment.
Now I see, I created single word wiki pages. When you do that it looks like title == wikiPath
|
I've looked through it, didn't see any errors 🎉 |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version didn't diff
wiki titleandwiki page path. This PR will diff them clearly in variable names.