-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tags pull step to drone config to show correct version hashes i… #6836
Conversation
Tags are pulled correctly, so proper versions should work now. Though I'm not quite sure how to test this since it needs a release... |
Damn I don't think it works (from the first build log):
|
From the build command, it appers to work now: https://drone.gitea.io/go-gitea/gitea/8634/1/10
|
Codecov Report
@@ Coverage Diff @@
## master #6836 +/- ##
=========================================
Coverage ? 41.21%
=========================================
Files ? 421
Lines ? 58120
Branches ? 0
=========================================
Hits ? 23955
Misses ? 30993
Partials ? 3172 Continue to review full report at Codecov.
|
Please send backport to 1.8 |
Does this fix #6806 ? |
Well it depends on what they mean by a stable output |
But yes things should now have 1.9.0+dev prefixed and similarly for 1.8 |
It should also fix #4782 as on the tag the version is good (no commit) even without the DRONE_TAG set :
|
Backport is up: #6840 |
As title.