Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added custom css file. Fixes #688 #784

Closed
wants to merge 1 commit into from
Closed

[WIP] Added custom css file. Fixes #688 #784

wants to merge 1 commit into from

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Jan 29, 2017

I have added a line to the gitea css file which imports custom.css. It is blank by default (so there are not any 404s), but because of #782, it can be overridden, therefore allowing custom css which can survive updates.

@lunny lunny added this to the 1.1.0 milestone Jan 29, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 29, 2017
@tboerger
Copy link
Member

This won't work. The css file gets generated from the less file, and I'm pretty sure that less will embed the imported css file.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Jan 29, 2017 via email

@pgaskin
Copy link
Contributor Author

pgaskin commented Jan 29, 2017

@tboerger Fixed. Proof:
gitea784

@tboerger
Copy link
Member

Maybe it's even better to provide a config variable, and maybe this can even be an array to include multiple files. Than you can even add files from any cdn by this option.

@pgaskin
Copy link
Contributor Author

pgaskin commented Jan 29, 2017

@tboerger Another way is to add CSS imports to the custom CSS file.

@tboerger
Copy link
Member

But this still loads an additional css file even for everybody who doesn't customize gitea

@pgaskin
Copy link
Contributor Author

pgaskin commented Jan 29, 2017

@tboerger I can add a config option to enable and disable the CSS file. What section should it go in?

@tboerger
Copy link
Member

I would prefer an option for a list of files that gets added instead of enabling or disabling the custom css file

@pgaskin
Copy link
Contributor Author

pgaskin commented Jan 29, 2017

@tboerger OK, what should the option be called, and what section should it go in?

@lunny
Copy link
Member

lunny commented Feb 14, 2017

Any update?

@pgaskin
Copy link
Contributor Author

pgaskin commented Feb 14, 2017 via email

@lunny lunny modified the milestones: 1.2.0, 1.1.0 Feb 15, 2017
@lunny
Copy link
Member

lunny commented Feb 15, 2017

OK. So let's move this to v1.2

@lunny
Copy link
Member

lunny commented Mar 11, 2017

Is this needed since we can override the public folder?

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 11, 2017

@lunny, yes because if we override the CSS file, it could get out of date and break the UI after an upgrade.

@pgaskin pgaskin changed the title Added custom css file. Fixes #688 [WIP] Added custom css file. Fixes #688 Mar 12, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

@tboerger @strk @lunny How should this work? Should there be a list of custom css files in the config, custom css directly in the config, a file for custom css, or something else?

@lunny
Copy link
Member

lunny commented Mar 13, 2017

@geek1011 I have no idea.

@lunny lunny modified the milestones: 1.x.x, 1.2.0 Apr 20, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Jun 25, 2017

I will do this later from scratch. Closing this for now.

@pgaskin pgaskin closed this Jun 25, 2017
@lunny lunny removed this from the 1.x.x milestone Jun 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants