-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Added custom css file. Fixes #688 #784
Conversation
This won't work. The css file gets generated from the less file, and I'm pretty sure that less will embed the imported css file. |
OK. I think I know how to fix that. Sorry about not testing it completely.
|
@tboerger Fixed. Proof: |
Maybe it's even better to provide a config variable, and maybe this can even be an array to include multiple files. Than you can even add files from any cdn by this option. |
@tboerger Another way is to add CSS imports to the custom CSS file. |
But this still loads an additional css file even for everybody who doesn't customize gitea |
@tboerger I can add a config option to enable and disable the CSS file. What section should it go in? |
I would prefer an option for a list of files that gets added instead of enabling or disabling the custom css file |
@tboerger OK, what should the option be called, and what section should it go in? |
Any update? |
Yes, but I will not be able to do it in time for the next version.
On Feb 14, 2017 8:37 AM, Lunny Xiao <notifications@github.com> wrote:
Any update?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#784 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANQ-1ZVz-Y8bLLSWvlyPPDW3P3Iojn8eks5rca4WgaJpZM4LwrrM>.
|
OK. So let's move this to v1.2 |
Is this needed since we can override the public folder? |
@lunny, yes because if we override the CSS file, it could get out of date and break the UI after an upgrade. |
@geek1011 I have no idea. |
I will do this later from scratch. Closing this for now. |
I have added a line to the gitea css file which imports custom.css. It is blank by default (so there are not any 404s), but because of #782, it can be overridden, therefore allowing custom css which can survive updates.